Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2349253002: Revert of Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest (Closed)

Created:
4 years, 3 months ago by iclelland
Modified:
4 years, 3 months ago
CC:
chromium-reviews, tfarina, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org, chongz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest (patchset #11 id:200001 of https://codereview.chromium.org/2197113002/ ) Reason for revert: Tests are failing on Mac ASAN builder. See details here: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1) First failed build: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/21876 Original issue's description: > Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest > > BUG=633136 > > Committed: https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237 > Cr-Commit-Position: refs/heads/master@{#419454} TBR=pkasting@chromium.org,chongz@chromium.org,sadrul@chromium.org,frankf@chromium.org,wez@chromium.org,samuong@chromium.org,tmoniuszko@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633136 Committed: https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac Cr-Commit-Position: refs/heads/master@{#419479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -249 lines) Patch
M chrome/test/chromedriver/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/key_converter_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_unittest.cc View 4 chunks +22 lines, -22 lines 0 comments Download
A chrome/test/chromedriver/test_util.h View 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/test_util.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/events/keycodes/platform_key_map_win_unittest.cc View 7 chunks +43 lines, -11 lines 0 comments Download
D ui/events/test/keyboard_layout.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ui/events/test/keyboard_layout.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/events/test/keyboard_layout_mac.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/events/test/keyboard_layout_win.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
iclelland
Created Revert of Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest
4 years, 3 months ago (2016-09-19 16:33:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349253002/1
4 years, 3 months ago (2016-09-19 16:34:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 16:35:06 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 16:37:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac
Cr-Commit-Position: refs/heads/master@{#419479}

Powered by Google App Engine
This is Rietveld 408576698