Issue 23533071: Fix uploading binary files to rietveld.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23533071: Fix uploading binary files to rietveld. (Closed)

Created:
7 years, 3 months ago by chrisphan

Modified:
7 years, 3 months ago

Reviewers:
iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Fix uploading binary files to rietveld. httplib chokes on concatenating the unicode string "url" and some bytecode in "data". BUG=169600

Patch Set 1 #

Patch Set 2 : Update #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/upload.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

chrisphan

On 2013/09/20 19:28:33, M-A Ruel wrote: > I'd prefer to fix the call sites. Done

7 years, 3 months ago (2013-09-20 19:55:50 UTC) #3

M-A Ruel

On 2013/09/20 19:55:50, chrisphan wrote: > On 2013/09/20 19:28:33, M-A Ruel wrote: > > I'd ...

7 years, 3 months ago (2013-09-20 19:59:11 UTC) #4

chrisphan

7 years, 3 months ago (2013-09-20 23:16:50 UTC) #5

On 2013/09/20 19:59:11, M-A Ruel wrote:
> On 2013/09/20 19:55:50, chrisphan wrote:
> > On 2013/09/20 19:28:33, M-A Ruel wrote:
> > > I'd prefer to fix the call sites.
> > 
> > Done
> 
> No, I meant the call sites in git_cl.py or whatever needed. AFAIK upload.py is
> doing fine when run stand alone.

Oops messed up this repo.  Moving CL to
https://chromiumcodereview.appspot.com/24172008

Expand Messages | Collapse Messages