third_party/upload.py - Issue 23533071: Fix uploading binary files to rietveld.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/upload.py

Issue 23533071: Fix uploading binary files to rietveld. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Update Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/upload.py

diff --git a/third_party/upload.py b/third_party/upload.py

index 31542663af90b4a3e344fac6512d6b29195d708b..be13ed3977573dabaa4003a05036ab3df599f81f 100755

--- a/third_party/upload.py

+++ b/third_party/upload.py

@@ -452,7 +452,7 @@ class AbstractRpcServer(object):

url = "%s%s" % (self.host, request_path)

if args:

url += "?" + urllib.urlencode(args)

- req = self._CreateRequest(url=url, data=payload)

+ req = self._CreateRequest(url=url.encode("utf-8"), data=payload)

req.add_header("Content-Type", content_type)

if extra_headers:

for header, value in extra_headers.items():

« no previous file with comments | « no previous file | no next file » | no next file with comments »