Chromium Code Reviews| Index: tools/telemetry/telemetry/page/page_test.py |
| diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py |
| index 405a621c9332131c1a6582c0afb9ebdd0d0a8e91..45e18787c503546fb52aedd2477d5f89c76b9b23 100644 |
| --- a/tools/telemetry/telemetry/page/page_test.py |
| +++ b/tools/telemetry/telemetry/page/page_test.py |
| @@ -3,7 +3,6 @@ |
| # found in the LICENSE file. |
| import logging |
| -from telemetry.core import util |
| from telemetry.page import test_expectations |
| from telemetry.page.actions import all_page_actions |
| from telemetry.page.actions import navigate |
| @@ -198,9 +197,10 @@ class PageTest(object): |
| if run_setup_methods: |
| self.DidRunAction(page, tab, action) |
| - # Closing the connections periodically is needed; otherwise we won't be |
| - # able to open enough sockets, and the pages will time out. |
| - util.CloseConnections(tab) |
| + # Note that we must not call util.CloseConnections here. Many tests |
|
tonyg
2013/09/04 00:02:24
My preference would be to just delete it without a
Ken Russell (switch to Gerrit)
2013/09/04 17:18:59
I've given this more thought and am leaving the co
|
| + # navigate to a URL in the first action and then wait for a condition |
| + # in the second action. Calling util.CloseConnections here often |
| + # aborts resource loads performed by the page. |
| def RunNavigateSteps(self, page, tab): |
| """Navigates the tab to the page URL attribute. |