chrome/common/benchmarking_messages.h - Issue 23533029: Fixed flakiness in WebGL conformance, and presumably other tests, under Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/benchmarking_messages.h

Issue 23533029: Fixed flakiness in WebGL conformance, and presumably other tests, under Telemetry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/benchmarking_messages.h

diff --git a/chrome/common/benchmarking_messages.h b/chrome/common/benchmarking_messages.h

index 02c8f3dc7dd667763e2e83002fb5d24f16a52856..6caa7a2ab464d1a62d24d9742857609e45a5640f 100644

--- a/chrome/common/benchmarking_messages.h

+++ b/chrome/common/benchmarking_messages.h

@@ -16,7 +16,10 @@

// Message sent from the renderer to the browser to request that the browser

// close all sockets. Used for debugging/testing.

-IPC_MESSAGE_CONTROL0(ChromeViewHostMsg_CloseCurrentConnections)

+//

+// This message must be synchronous so that the test harness can not

+// issue further network requests before it completes.

+IPC_SYNC_MESSAGE_CONTROL0_0(ChromeViewHostMsg_CloseCurrentConnections)

tonyg 2013/09/04 00:02:24 lgtm as long as you've verified that the comment s

Ken Russell (switch to Gerrit) 2013/09/04 17:18:59 The comment's still accurate. This message is igno

// Message sent from the renderer to the browser to request that the browser

// enable or disable the cache. Used for debugging/testing.

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_test.py » ('j') | tools/telemetry/telemetry/page/page_test.py » ('J')