Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 23532086: To use C++ API for BreakIterator in Blink, port getRuleStatus from ICU 52 (Closed)

Created:
7 years, 3 months ago by jungshik at Google
Modified:
7 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

To use C++ API for BreakIterator in Blink, port getRuleStatus from ICU 52 See https://codereview.chromium.org/23618052 for the Blink change. Patch by Igor Oliveira. Original review : https://codereview.chromium.org/23480090/ BUG=232922 TEST=ICU is built and Blink is built with Blink CL above once ICU is rolled. TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224814

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -2 lines) Patch
M README.chromium View 1 1 chunk +3 lines, -2 lines 0 comments Download
A patches/breakiterator.patch View 1 1 chunk +140 lines, -0 lines 0 comments Download
M source/common/brkiter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M source/common/unicode/brkiter.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
7 years, 3 months ago (2013-09-23 22:41:24 UTC) #1
jungshik at Google
7 years, 3 months ago (2013-09-23 22:41:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r224814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698