Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 23480090: Add BreakIterator::getRuleStatus (Closed)

Created:
7 years, 3 months ago by igoroliveira
Modified:
7 years, 3 months ago
CC:
Mark Mentovai
Base URL:
https://chromium.googlesource.com/chromium/deps/icu46.git@master
Visibility:
Public.

Description

The CL https://codereview.chromium.org/23618052/ depends of an API that will be added by libicu 52, BreakIterator::getRuleStatus. This patch is just a copy and paste of the libicu 52 API into chromium libicu. BUG=N/A

Patch Set 1 #

Patch Set 2 : Proposed patch #

Total comments: 1

Patch Set 3 : Proposed patch v3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2 lines) Patch
M README.chromium View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A patches/breakiterator.patch View 1 1 chunk +74 lines, -0 lines 0 comments Download
M source/common/brkiter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M source/common/unicode/brkiter.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
igoroliveira
7 years, 3 months ago (2013-09-17 21:52:22 UTC) #1
igoroliveira
On 2013/09/17 21:52:22, Igor Oliveira wrote: Adding icu OWNER.
7 years, 3 months ago (2013-09-17 22:06:19 UTC) #2
Mark Mentovai
→jungshik
7 years, 3 months ago (2013-09-17 22:58:04 UTC) #3
jungshik at Google
On 2013/09/17 22:58:04, Mark Mentovai wrote: > →jungshik I'm going to update ICU to 52.1 ...
7 years, 3 months ago (2013-09-18 00:28:34 UTC) #4
igoroliveira
On 2013/09/18 00:28:34, Jungshik Shin wrote: > On 2013/09/17 22:58:04, Mark Mentovai wrote: > > ...
7 years, 3 months ago (2013-09-18 20:41:29 UTC) #5
jungshik at Google
LGTM with one nit below addressed. BTW, we have to keep this patch even after ...
7 years, 3 months ago (2013-09-18 20:55:19 UTC) #6
igoroliveira
On 2013/09/18 20:55:19, Jungshik Shin wrote: > LGTM with one nit below addressed. > > ...
7 years, 3 months ago (2013-09-19 14:06:22 UTC) #7
igoroliveira
Adding third_party owners.
7 years, 3 months ago (2013-09-19 17:55:27 UTC) #8
jungshik at Google
On 2013/09/19 17:55:27, Igor Oliveira wrote: > Adding third_party owners. After this goes in, you ...
7 years, 3 months ago (2013-09-19 19:38:39 UTC) #9
igoroliveira
On 2013/09/19 19:38:39, Jungshik Shin wrote: > On 2013/09/19 17:55:27, Igor Oliveira wrote: > > ...
7 years, 3 months ago (2013-09-19 19:39:49 UTC) #10
jungshik at Google
On 2013/09/19 19:39:49, Igor Oliveira wrote: > On 2013/09/19 19:38:39, Jungshik Shin wrote: > > ...
7 years, 3 months ago (2013-09-23 16:43:40 UTC) #11
jungshik at Google
7 years, 3 months ago (2013-09-23 22:42:34 UTC) #12
Landed manually with a little change in the patch file and README.chromium. See
https://codereview.chromium.org/23532086/

Powered by Google App Engine
This is Rietveld 408576698