Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23532085: [chormium_android api] Set KLP and x86 GYP_DEFINES. (Closed)

Created:
7 years, 3 months ago by Siva Chandra
Modified:
7 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

[chormium_android api] Set KLP and x86 GYP_DEFINES. BUG=286509 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=224797

Patch Set 1 #

Patch Set 2 : Remove a spurious pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -144 lines) Patch
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-android.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-android.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-android.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-chromeos.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-chromeos.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-chromeos.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-linux.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-linux.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-linux.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-android.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-android.arm.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-android.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-android.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-android.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-android.mips.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-chromeos.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-chromeos.arm.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-chromeos.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-chromeos.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-chromeos.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-chromeos.mips.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.arm.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.mips.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-mac.intel.32-to-ios.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-mac.intel.32-to-mac.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-mac.intel.64-to-ios.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-mac.intel.64-to-mac.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-mac.intel.64-to-mac.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-win.intel.32-to-win.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-win.intel.64-to-win.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-win.intel.64-to-win.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-android.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-android.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-android.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-chromeos.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-chromeos.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-chromeos.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-linux.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-linux.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-linux.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-android.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-android.arm.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-android.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-android.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-android.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-android.mips.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-chromeos.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-chromeos.arm.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-chromeos.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-chromeos.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-chromeos.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-chromeos.mips.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.arm.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.mips.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.mips.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-mac.intel.32-to-ios.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-mac.intel.32-to-mac.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-mac.intel.64-to-ios.arm.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-mac.intel.64-to-mac.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-mac.intel.64-to-mac.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-win.intel.32-to-win.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-win.intel.64-to-win.intel.32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-win.intel.64-to-win.intel.64.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/chromium_config.py View 1 1 chunk +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/android_builder.expected/klp_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/android_builder.expected/x86_builder.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Siva Chandra
7 years, 3 months ago (2013-09-23 20:39:16 UTC) #1
iannucci
lgtm
7 years, 3 months ago (2013-09-23 21:36:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/23532085/3001
7 years, 3 months ago (2013-09-23 21:40:13 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-23 21:41:59 UTC) #4
Message was sent while issue was closed. 
Change committed as 224797

Powered by Google App Engine
This is Rietveld 408576698