Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/chromium_android/chromium_config.py

Issue 23532085: [chormium_android api] Set KLP and x86 GYP_DEFINES. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Remove a spurious pass Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/chromium/config.expected/Release-win.intel.64-to-win.intel.64.json ('k') | scripts/slave/recipes/android/android_builder.expected/klp_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/chromium_config.py
diff --git a/scripts/slave/recipe_modules/chromium_android/chromium_config.py b/scripts/slave/recipe_modules/chromium_android/chromium_config.py
index ae2ed3cea93a8afe99817c7c48a9605056a1d815..3aecacbbcc612569e143acc512e6ff7a8504dc7c 100644
--- a/scripts/slave/recipe_modules/chromium_android/chromium_config.py
+++ b/scripts/slave/recipe_modules/chromium_android/chromium_config.py
@@ -33,11 +33,14 @@ def component_builder(c):
@CONFIG_CTX(includes=['main_builder'])
def x86_builder(c):
- pass
+ c.gyp_env.GYP_DEFINES['target_arch'] = 'x86'
@CONFIG_CTX(includes=['main_builder'])
def klp_builder(c):
- pass
+ gyp_defs = c.gyp_env.GYP_DEFINES
+ gyp_defs['android_sdk_version'] = 'KeyLimePie'
+ gyp_defs['android_sdk_root'] = ['third_party', 'android_tools_internal',
+ 'sdk']
@CONFIG_CTX(includes=['main_builder'])
def try_builder(c):
« no previous file with comments | « scripts/slave/recipe_modules/chromium/config.expected/Release-win.intel.64-to-win.intel.64.json ('k') | scripts/slave/recipes/android/android_builder.expected/klp_builder.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698