Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: third_party/webdriver/patch.diff

Issue 23531035: [chromedriver] Cherrypick atoms fix for toggling multi select options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/webdriver/atoms.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/webdriver/patch.diff
diff --git a/third_party/webdriver/patch.diff b/third_party/webdriver/patch.diff
index 8acc931767839be2fd1ac5c9666e947c44354f95..e13623cd90faf0e56d078a1c582ccc2b415b3314 100644
--- a/third_party/webdriver/patch.diff
+++ b/third_party/webdriver/patch.diff
@@ -1,8 +1,20 @@
-Index: javascript/chrome-driver/build.desc
-===================================================================
---- javascript/chrome-driver/build.desc (revision 18456)
-+++ javascript/chrome-driver/build.desc (working copy)
-@@ -24,6 +24,11 @@
+diff --git a/javascript/atoms/device.js b/javascript/atoms/device.js
+index e2693f8..3731db3 100644
+--- a/javascript/atoms/device.js
++++ b/javascript/atoms/device.js
+@@ -627,6 +627,7 @@ bot.Device.prototype.maybeToggleOption = function() {
+ // Only WebKit fires the change event itself and only for multi-selects,
+ // except for Android versions >= 4.0.
+ if (!(goog.userAgent.WEBKIT && select.multiple) ||
++ (goog.userAgent.product.CHROME && bot.userAgent.isProductVersion(28)) ||
+ (goog.userAgent.product.ANDROID && bot.userAgent.isProductVersion(4))) {
+ bot.events.fire(select, bot.events.EventType.CHANGE);
+ }
+diff --git a/javascript/chrome-driver/build.desc b/javascript/chrome-driver/build.desc
+index 423c450..1889095 100644
+--- a/javascript/chrome-driver/build.desc
++++ b/javascript/chrome-driver/build.desc
+@@ -24,6 +24,11 @@ js_fragment(name = "get_page_zoom",
function = "webdriver.chrome.getPageZoom",
deps = [ ":deps" ])
@@ -14,7 +26,7 @@ Index: javascript/chrome-driver/build.desc
js_test(name = "test",
srcs = [ "test/*_test.html" ],
deps = [
-@@ -39,6 +44,7 @@
+@@ -39,6 +44,7 @@ js_fragment_cpp(name = "atoms",
"//javascript/chrome-driver:get_location_in_view:chrome",
"//javascript/chrome-driver:get_page_zoom:chrome",
"//javascript/chrome-driver:is_element_clickable:chrome",
« no previous file with comments | « third_party/webdriver/atoms.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698