Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: third_party/webdriver/patch.diff

Issue 23531035: [chromedriver] Cherrypick atoms fix for toggling multi select options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « third_party/webdriver/atoms.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Index: javascript/chrome-driver/build.desc 1 diff --git a/javascript/atoms/device.js b/javascript/atoms/device.js
2 =================================================================== 2 index e2693f8..3731db3 100644
3 --- javascript/chrome-driver/build.desc»(revision 18456) 3 --- a/javascript/atoms/device.js
4 +++ javascript/chrome-driver/build.desc»(working copy) 4 +++ b/javascript/atoms/device.js
5 @@ -24,6 +24,11 @@ 5 @@ -627,6 +627,7 @@ bot.Device.prototype.maybeToggleOption = function() {
6 // Only WebKit fires the change event itself and only for multi-selects,
7 // except for Android versions >= 4.0.
8 if (!(goog.userAgent.WEBKIT && select.multiple) ||
9 + (goog.userAgent.product.CHROME && bot.userAgent.isProductVersion(28)) ||
10 (goog.userAgent.product.ANDROID && bot.userAgent.isProductVersion(4))) {
11 bot.events.fire(select, bot.events.EventType.CHANGE);
12 }
13 diff --git a/javascript/chrome-driver/build.desc b/javascript/chrome-driver/buil d.desc
14 index 423c450..1889095 100644
15 --- a/javascript/chrome-driver/build.desc
16 +++ b/javascript/chrome-driver/build.desc
17 @@ -24,6 +24,11 @@ js_fragment(name = "get_page_zoom",
6 function = "webdriver.chrome.getPageZoom", 18 function = "webdriver.chrome.getPageZoom",
7 deps = [ ":deps" ]) 19 deps = [ ":deps" ])
8 20
9 +js_fragment(name = "touch_single_tap", 21 +js_fragment(name = "touch_single_tap",
10 + module = "bot.action", 22 + module = "bot.action",
11 + function = "bot.action.tap", 23 + function = "bot.action.tap",
12 + deps = [ "//javascript/atoms:deps" ]) 24 + deps = [ "//javascript/atoms:deps" ])
13 + 25 +
14 js_test(name = "test", 26 js_test(name = "test",
15 srcs = [ "test/*_test.html" ], 27 srcs = [ "test/*_test.html" ],
16 deps = [ 28 deps = [
17 @@ -39,6 +44,7 @@ 29 @@ -39,6 +44,7 @@ js_fragment_cpp(name = "atoms",
18 "//javascript/chrome-driver:get_location_in_view:chrome", 30 "//javascript/chrome-driver:get_location_in_view:chrome",
19 "//javascript/chrome-driver:get_page_zoom:chrome", 31 "//javascript/chrome-driver:get_page_zoom:chrome",
20 "//javascript/chrome-driver:is_element_clickable:chrome", 32 "//javascript/chrome-driver:is_element_clickable:chrome",
21 + "//javascript/chrome-driver:touch_single_tap:chrome", 33 + "//javascript/chrome-driver:touch_single_tap:chrome",
22 "//javascript/webdriver/atoms:clear:chrome", 34 "//javascript/webdriver/atoms:clear:chrome",
23 "//javascript/webdriver/atoms:clear_local_storage:chrome", 35 "//javascript/webdriver/atoms:clear_local_storage:chrome",
24 "//javascript/webdriver/atoms:clear_session_storage:chrome", 36 "//javascript/webdriver/atoms:clear_session_storage:chrome",
OLDNEW
« no previous file with comments | « third_party/webdriver/atoms.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698