Issue 23531035: [chromedriver] Cherrypick atoms fix for toggling multi select options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23531035: [chromedriver] Cherrypick atoms fix for toggling multi select options. (Closed)

Created:
7 years, 3 months ago by kkania

Modified:
7 years, 3 months ago

Reviewers:
chrisgao (Use stgao instead)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Cherrypick atoms fix for toggling multi select options. BUG=none R=chrisgao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221408

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+919 lines, -884 lines)			Patch
	M	third_party/webdriver/atoms.cc	View		6 chunks	+901 lines, -878 lines	0 comments	Download
	M	third_party/webdriver/patch.diff	View		2 chunks	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/23531035/1

7 years, 3 months ago (2013-09-04 23:59:17 UTC) #3

commit-bot: I haz the power

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82854

7 years, 3 months ago (2013-09-05 01:09:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/23531035/1

7 years, 3 months ago (2013-09-05 04:52:09 UTC) #5

commit-bot: I haz the power

7 years, 3 months ago (2013-09-05 05:19:30 UTC) #6

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

Expand Messages | Collapse Messages