Source/wtf/TypeTraits.h - Issue 23531003: Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/TypeTraits.h

Issue 23531003: Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/wtf/TypeTraits.h

diff --git a/Source/wtf/TypeTraits.h b/Source/wtf/TypeTraits.h

index 45e0714b827aef60d8ff0d9656b36f93f7d12b8f..1a98503638c8f211a313024b9cc915af7b30711c 100644

--- a/Source/wtf/TypeTraits.h

+++ b/Source/wtf/TypeTraits.h

@@ -247,10 +247,6 @@ namespace WTF {

#define EnsurePtrConvertibleType(ReturnType, From, To) \

typename EnableIf<IsPointerConvertible<From, To>::Value, ReturnType>::Type

Nico 2013/08/29 19:58:47 …here it is, right? I don't see the value in remov

Nico 2013/08/31 20:51:34 Any thoughts on this comment?

-#define EnsurePtrConvertibleArgDecl(From, To) \

- EnsurePtrConvertibleType(bool, From, To) = true

-#define EnsurePtrConvertibleArgDefn(From, To) \

- EnsurePtrConvertibleType(bool, From, To)

} // namespace WTF

« Source/wtf/PassRefPtr.h ('K') | « Source/wtf/RefPtr.h ('k') | no next file » | no next file with comments »