Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness

Source/wtf/TypeTraits.h

  /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 228 matching lines @@
     // but the implementation returns false for built-in types. We add the extra IsPod condition to
     // work around this.
     template <typename T> struct HasTrivialConstructor {
         static const bool value = __has_trivial_constructor(T) || IsPod<RemoveConstVolatile<T> >::value;
     };
     template <typename T> struct HasTrivialDestructor {
         static const bool value = __has_trivial_destructor(T) || IsPod<RemoveConstVolatile<T> >::value;
     };
 
 #define EnsurePtrConvertibleType(ReturnType, From, To) \
     typename EnableIf<IsPointerConvertible<From, To>::Value, ReturnType>::Type

[Nico, 2013/08/29 19:58:47]

…here it is, right? I don't see the value in removing the two defines here if
they are added back in in two other places.

[Nico, 2013/08/31 20:51:34]

Any thoughts on this comment?

-#define EnsurePtrConvertibleArgDecl(From, To) \
-    EnsurePtrConvertibleType(bool, From, To) = true
-#define EnsurePtrConvertibleArgDefn(From, To) \
-    EnsurePtrConvertibleType(bool, From, To)
 
 } // namespace WTF
 
 namespace WebCore {
 
 class JSONValue;
 
 } // namespace WebCore
 
 namespace WTF {
 
     // FIXME: Disable pointer conversion checking against JSONValue.
     // The current CodeGeneratorInspector.py generates code which upcasts to JSONValue from undefined types.
     template<typename From> class IsPointerConvertible<From, WebCore::JSONValue> {
     public:
         enum {
             Value = true
         };
     };
 
 } // namespace WTF
 
 
 #endif // TypeTraits_h