Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 2353013003: Re-land "Make CPDF_IndirectObjectHolder use unique_ptr to objects"" (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Re-land "Make CPDF_IndirectObjectHolder use unique_ptr to objects"" This reverts commit 81e1e3fd2d33478733e47bd007b76fac1a663e74. Committed: https://pdfium.googlesource.com/pdfium/+/5b7c9bbf6c26ca272706814ad3598894ce5e4e3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp View 5 chunks +8 lines, -18 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h View 4 chunks +4 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_object.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Dan, quick check before re-landing.
4 years, 3 months ago (2016-09-20 18:31:45 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-09-20 18:34:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353013003/1
4 years, 3 months ago (2016-09-20 19:02:17 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:02:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5b7c9bbf6c26ca272706814ad3598894ce5e...

Powered by Google App Engine
This is Rietveld 408576698