core/fpdfapi/fpdf_parser/cfdf_document.cpp - Issue 2353013003: Re-land "Make CPDF_IndirectObjectHolder use unique_ptr to objects""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cfdf_document.cpp

Issue 2353013003: Re-land "Make CPDF_IndirectObjectHolder use unique_ptr to objects"" (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cfdf_document.cpp

diff --git a/core/fpdfapi/fpdf_parser/cfdf_document.cpp b/core/fpdfapi/fpdf_parser/cfdf_document.cpp

index 01829481730f2acccbf8f56170468c190c29ce13..92b20cafd83f83c9101a7ef826ec185d73a0fb69 100644

--- a/core/fpdfapi/fpdf_parser/cfdf_document.cpp

+++ b/core/fpdfapi/fpdf_parser/cfdf_document.cpp

@@ -90,7 +90,8 @@ FX_BOOL CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const {

buf << "%FDF-1.2\r\n";

for (const auto& pair : *this)

- buf << pair.first << " 0 obj\r\n" << pair.second << "\r\nendobj\r\n\r\n";

+ buf << pair.first << " 0 obj\r\n"

+ << pair.second.get() << "\r\nendobj\r\n\r\n";

buf << "trailer\r\n<</Root " << m_pRootDict->GetObjNum()

<< " 0 R>>\r\n%%EOF\r\n";