chrome/common/extensions/api/_api_features.json - Issue 23530029: Support webview tag when the container extension is embedded in a webUI

Unified Diff: chrome/common/extensions/api/_api_features.json

Issue 23530029: Support webview tag when the container extension is embedded in a webUI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed unnecessary lines from document_custom_bindings Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/_api_features.json

diff --git a/chrome/common/extensions/api/_api_features.json b/chrome/common/extensions/api/_api_features.json

index a4f77eb7bc8dd9a8d8525dc6a8cf3b44c7ca4113..7125d6d63c9707235bcd20c9c70a9338bcb83838 100644

--- a/chrome/common/extensions/api/_api_features.json

+++ b/chrome/common/extensions/api/_api_features.json

@@ -614,7 +614,7 @@

"webview": {

"internal": true,

"dependencies": ["permission:webview"],

- "contexts": ["blessed_extension"]

+ "contexts": ["blessed_extension", "unblessed_extension"]

Charlie Reis 2013/09/13 21:17:24 What does unblessed_extension mean, and why do we

guohui 2013/09/16 22:27:02 It means a JavaScript context for an inactive exte

Charlie Reis 2013/09/18 17:42:23 Ok. Fady and I talked about this and we think it'

guohui 2013/09/19 13:48:41 how should we proceed with the security audit? Do

Charlie Reis 2013/09/19 17:21:22 I'll need to look over the existing webview API wi

guohui 2013/09/19 17:59:11 As suggested by Fady, i ll refactor this part into

"windows": {

"dependencies": ["api:tabs"],