content/browser/web_contents/render_view_host_manager.cc - Issue 23530029: Support webview tag when the container extension is embedded in a webUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/render_view_host_manager.cc

Issue 23530029: Support webview tag when the container extension is embedded in a webUI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fady's comment addressed Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/document_custom_bindings.cc ('K') | « content/browser/browser_plugin/browser_plugin_guest_manager.cc ('k') | content/common/browser_plugin/browser_plugin_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/render_view_host_manager.cc

diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc

index 00811167c6c5f99143aafecbe2c924eab7d91b09..ad94a79c0c8b83c18c120f73133e7f992c1d6880 100644

--- a/content/browser/web_contents/render_view_host_manager.cc

+++ b/content/browser/web_contents/render_view_host_manager.cc

@@ -698,9 +698,9 @@ int RenderViewHostManager::CreateRenderView(

bool RenderViewHostManager::InitRenderView(RenderViewHost* render_view_host,

int opener_route_id) {

- // If the pending navigation is to a WebUI, tell the RenderView about any

- // bindings it will need enabled.

- if (pending_web_ui())

+ // If the pending navigation is to a WebUI and the RenderView is not in a

+ // guest process, tell the RenderView about any bindings it will need enabled.

+ if (pending_web_ui() && !render_view_host->GetProcess()->IsGuest())

render_view_host->AllowBindings(pending_web_ui()->GetBindings());

return delegate_->CreateRenderViewForRenderManager(render_view_host,