Issue 23530010: Make CSSStyleSheet.insertRule() / deleteRule() arguments mandatory

Issue 23530010: Make CSSStyleSheet.insertRule() / deleteRule() arguments mandatory (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, arv (Not doing code reviews)

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, do-not-use, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make CSSStyleSheet.insertRule() / deleteRule() arguments mandatory Make CSSStyleSheet.insertRule() / deleteRule() arguments mandatory to match the specification: http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSStyleSheet This behavior is consistent with Firefox 23 and IE10. It is confusing what is supposed to happen when the arguments are omitted. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157074

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -18 lines)			Patch
M	LayoutTests/editing/selection/first-letter-selection-crash.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/css/counters/asterisk-counter-update-after-layout-crash.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View	1 2	2 chunks	+2 lines, -7 lines	0 comments	Download
M	LayoutTests/fast/shapes/resources/simple-rectangle.js	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/css/CSSStyleSheet.idl	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 7 (0 generated)

do-not-use

Validated on IE and Firefox using: http://jsfiddle.net/yGJpR/2/

7 years, 3 months ago (2013-08-30 11:44:49 UTC) #1

tkent

lgtm Please update editing/selection/first-letter-selection-crash.html and fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic.html too.

7 years, 3 months ago (2013-09-02 02:55:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23530010/7001

7 years, 3 months ago (2013-09-02 06:47:49 UTC) #4

commit-bot: I haz the power

Failed to request the patch to try. Please note that binary files are still unsupported ...

7 years, 3 months ago (2013-09-02 08:12:00 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23530010/19001

7 years, 3 months ago (2013-09-02 08:26:49 UTC) #6

Message was sent while issue was closed.

Change committed as 157074