LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js - Issue 23530010: Make CSSStyleSheet.insertRule() / deleteRule() arguments mandatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

Issue 23530010: Make CSSStyleSheet.insertRule() / deleteRule() arguments mandatory (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt ('k') | LayoutTests/fast/shapes/resources/simple-rectangle.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

diff --git a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

index 0fccd460c757d4b2d58813c1658ebcde92b39281..6d385ec132719060ff3f123bd23cd91434a3baee 100644

--- a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

+++ b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

@@ -100,11 +100,6 @@ var ruleText = selector + " { " + styleText + " }";

var testElementContainer = document.createElement("div");

document.body.appendChild(testElementContainer);

-function createCSSStyleSheet()

- return document.createElement("style").sheet;

function createFromMarkup(markup)

{

var range = document.createRange();

@@ -208,8 +203,8 @@ shouldBe("nonNumericPolicy('createCSSStyleDeclaration().item(x)')", "'any type a

// CSSStyleSheet

-shouldBe("nonNumericPolicy('createCSSStyleSheet().insertRule(ruleText, x)')", "'any type allowed'");

-shouldBe("nonNumericPolicy('createCSSStyleSheet().deleteRule(x)')", "'any type allowed'");

+shouldBe("nonNumericPolicy('createCSSStyleSheet().insertRule(ruleText, x)')", "'any type allowed (but not omitted)'");

+shouldBe("nonNumericPolicy('createCSSStyleSheet().deleteRule(x)')", "'any type allowed (but not omitted)'");

shouldBe("nonNumericPolicy('createCSSStyleSheet().addRule(selector, styleText, x)')", "'any type allowed'");

shouldBe("nonNumericPolicy('createCSSStyleSheet().removeRule(x)')", "'any type allowed'");