Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2352923003:
GN: fold :vulkan into :gpu. (Closed)
DescriptionGN: fold :vulkan into :gpu.
Obviously, :vulkan can't be used without :gpu, but more subtly,
:gpu needs to see SK_VULKAN defined if we're using Vulkan.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003
NOTREECHECKS=true
Committed: https://skia.googlesource.com/skia/+/e9fb3d553cbff3b86e4aae751c75b742d425c7af
Patch Set 1 #
Total comments: 1
Messages
Total messages: 15 (8 generated)
Description was changed from ========== GN: fold :vulkan into :gpu. Obviously, :vulkan can't be used without :gpu, and more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: ========== to ========== GN: fold :vulkan into :gpu. Obviously, :vulkan can't be used without :gpu, and more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 ==========
Description was changed from ========== GN: fold :vulkan into :gpu. Obviously, :vulkan can't be used without :gpu, and more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 ========== to ========== GN: fold :vulkan into :gpu. Obviously, :vulkan can't be used without :gpu, and more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 NOTREECHECKS=true ==========
Description was changed from ========== GN: fold :vulkan into :gpu. Obviously, :vulkan can't be used without :gpu, and more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 NOTREECHECKS=true ========== to ========== GN: fold :vulkan into :gpu. Obviously, :vulkan can't be used without :gpu, but more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 NOTREECHECKS=true ==========
mtklein@chromium.org changed reviewers: + egdaniel@google.com
lgtm with the one question https://codereview.chromium.org/2352923003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2352923003/diff/1/BUILD.gn#newcode325 BUILD.gn:325: libs = [] is there any reason why public_defines is initialized above and libs here?
On 2016/09/20 at 20:52:57, egdaniel wrote: > lgtm with the one question > > https://codereview.chromium.org/2352923003/diff/1/BUILD.gn > File BUILD.gn (right): > > https://codereview.chromium.org/2352923003/diff/1/BUILD.gn#newcode325 > BUILD.gn:325: libs = [] > is there any reason why public_defines is initialized above and libs here? Hmm. Not really. public_defines is a special thing that only optional knows about (just like enabled), so I try to put that near the top. I was going to say that I usually try to do the rest as deps - srcs - libs, but I think I see all permutations in here.
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on master.client.skia.android (JOB_FAILED, http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-N...)
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== GN: fold :vulkan into :gpu. Obviously, :vulkan can't be used without :gpu, but more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 NOTREECHECKS=true ========== to ========== GN: fold :vulkan into :gpu. Obviously, :vulkan can't be used without :gpu, but more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/e9fb3d553cbff3b86e4aae751c75b742d425c7af ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e9fb3d553cbff3b86e4aae751c75b742d425c7af |
