Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: BUILD.gn

Issue 2352923003: GN: fold :vulkan into :gpu. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index d9f7d79bee4086b9a7f44d644fe634fabdf660b7..4e78a1c61991a73b07ba01abaf712f62be8925db 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -303,6 +303,8 @@ optional("gif") {
optional("gpu") {
enabled = skia_enable_gpu
+ public_defines = []
+
sources = skia_gpu_sources + [ "src/gpu/gl/GrGLDefaultInterface_native.cpp" ]
# These paths need to be absolute to match the ones produced by shared_sources.gni.
@@ -320,6 +322,13 @@ optional("gpu") {
} else {
sources += [ "src/gpu/gl/GrGLCreateNativeInterface_none.cpp" ]
}
+ libs = []
egdaniel 2016/09/20 20:52:57 is there any reason why public_defines is initiali
+
+ if (skia_use_vulkan) {
+ public_defines += [ "SK_VULKAN" ]
+ sources += skia_vk_sources
+ libs += [ "vulkan" ]
+ }
}
optional("jpeg") {
@@ -379,13 +388,6 @@ optional("typeface_freetype") {
]
}
-optional("vulkan") {
- enabled = skia_use_vulkan
- public_defines = [ "SK_VULKAN" ]
- libs = [ "vulkan" ]
- sources = skia_vk_sources
-}
-
optional("webp") {
enabled = skia_use_libwebp
public_defines = [ "SK_HAS_WEBP_LIBRARY" ]
@@ -438,7 +440,6 @@ component("skia") {
":sse42",
":ssse3",
":typeface_freetype",
- ":vulkan",
":webp",
":xml",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698