Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 23529006: Move event handler to window_selector to ensure correct lifetime. (Closed)

Created:
7 years, 3 months ago by flackr
Modified:
7 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Move event handler to window_selector to ensure correct lifetime. BUG=279562 TEST=With --ash-enable-overview-mode, start alt-tabbing, click a window, then press and release alt. There should be no crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221123

Patch Set 1 #

Patch Set 2 : Move used includes. #

Patch Set 3 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -57 lines) Patch
M ash/wm/overview/window_selector.h View 2 chunks +5 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 2 3 chunks +42 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector_controller.h View 3 chunks +0 lines, -9 lines 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 1 3 chunks +0 lines, -44 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
flackr
PTAL, this fixes a crash resulting from not cleaning up the alt key event listener. ...
7 years, 3 months ago (2013-09-03 15:15:24 UTC) #1
Daniel Erat
lgtm
7 years, 3 months ago (2013-09-03 15:33:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/23529006/11007
7 years, 3 months ago (2013-09-03 15:45:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=75028
7 years, 3 months ago (2013-09-04 00:41:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/23529006/11007
7 years, 3 months ago (2013-09-04 00:51:12 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 02:34:12 UTC) #6
Message was sent while issue was closed.
Change committed as 221123

Powered by Google App Engine
This is Rietveld 408576698