Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1752)

Unified Diff: net/quic/core/quic_connection_test.cc

Issue 2352803002: Deprecate FLAGS_quic_close_connection_on_packet_too_large. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_connection.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_connection_test.cc
diff --git a/net/quic/core/quic_connection_test.cc b/net/quic/core/quic_connection_test.cc
index 428fb0e9902575ef3a275668a11241d559ace11d..0ce77b23c67e1259e1ee5577a26d4dc4f0424c27 100644
--- a/net/quic/core/quic_connection_test.cc
+++ b/net/quic/core/quic_connection_test.cc
@@ -5148,7 +5148,6 @@ TEST_P(QuicConnectionTest, ClientReceivesRejOnNonCryptoStream) {
}
TEST_P(QuicConnectionTest, CloseConnectionOnPacketTooLarge) {
- FLAGS_quic_close_connection_on_packet_too_large = true;
SimulateNextPacketTooLarge();
// Although the data packet cannot be written, the send packet manager is
// informed. Also a connection close packet is sent.
@@ -5162,7 +5161,6 @@ TEST_P(QuicConnectionTest, CloseConnectionOnPacketTooLarge) {
TEST_P(QuicConnectionTest, AlwaysGetPacketTooLarge) {
// Test even we always get packet too large, we do not infinitely try to send
// close packet.
- FLAGS_quic_close_connection_on_packet_too_large = true;
AlwaysGetPacketTooLarge();
EXPECT_CALL(*send_algorithm_, OnPacketSent(_, _, _, _, _)).Times(2);
EXPECT_CALL(visitor_, OnConnectionClosed(QUIC_PACKET_WRITE_ERROR, _,
« no previous file with comments | « net/quic/core/quic_connection.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698