Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: net/quic/core/quic_connection.cc

Issue 2352803002: Deprecate FLAGS_quic_close_connection_on_packet_too_large. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/core/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_connection.cc
diff --git a/net/quic/core/quic_connection.cc b/net/quic/core/quic_connection.cc
index 1cacb4956c2ef15286e33e12662e036c8368cedc..3e82f28a1ee0140d632174034025817774b85f14 100644
--- a/net/quic/core/quic_connection.cc
+++ b/net/quic/core/quic_connection.cc
@@ -1759,7 +1759,7 @@ bool QuicConnection::ShouldDiscardPacket(const SerializedPacket& packet) {
}
void QuicConnection::OnWriteError(int error_code) {
- if (FLAGS_quic_close_connection_on_packet_too_large && write_error_occured_) {
+ if (write_error_occured_) {
// A write error already occurred. The connection is being closed.
return;
}
@@ -1772,12 +1772,10 @@ void QuicConnection::OnWriteError(int error_code) {
// We can't send an error as the socket is presumably borked.
switch (error_code) {
case kMessageTooBigErrorCode:
- if (FLAGS_quic_close_connection_on_packet_too_large) { // NOLINT
- CloseConnection(
- QUIC_PACKET_WRITE_ERROR, error_details,
- ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET_WITH_NO_ACK);
- break;
- }
+ CloseConnection(
+ QUIC_PACKET_WRITE_ERROR, error_details,
+ ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET_WITH_NO_ACK);
+ break;
default:
// We can't send an error as the socket is presumably borked.
TearDownLocalConnectionState(QUIC_PACKET_WRITE_ERROR, error_details,
« no previous file with comments | « no previous file | net/quic/core/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698