LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js - Issue 23528004: [CSS Grid Layout] Update named grid lines syntax to the last version of the specs

Unified Diff: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 23528004: [CSS Grid Layout] Update named grid lines syntax to the last version of the specs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@named

Patch Set: Final patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt ('k') | LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js » ('j') | Source/core/css/CSSGridLineNamesValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

index 78e7c4816c2d2de15440af92eac8eddeec4a7032..222607ea07c106b9a8d347a9ef49f7b0924955fe 100755

--- a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

+++ b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

@@ -84,8 +84,8 @@ function testInherit()

{

var parentElement = document.createElement("div");

document.body.appendChild(parentElement);

- parentElement.style.gridDefinitionColumns = "50px 'last'";

- parentElement.style.gridDefinitionRows = "'first' 101%";

+ parentElement.style.gridDefinitionColumns = "50px (last)";

+ parentElement.style.gridDefinitionRows = "(first) 101%";

element = document.createElement("div");

parentElement.appendChild(element);

@@ -93,8 +93,8 @@ function testInherit()

element.style.height = "100px";

element.style.gridDefinitionColumns = "inherit";

element.style.gridDefinitionRows = "inherit";

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-columns')", "'50px last'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-rows')", "'first 101px'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-columns')", "'50px (last)'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-rows')", "'(first) 101px'");

document.body.removeChild(parentElement);

}

@@ -109,10 +109,10 @@ function testInitial()

element.style.display = "grid";

element.style.width = "300px";

element.style.height = "150px";

- element.style.gridDefinitionColumns = "150% 'last'";

- element.style.gridDefinitionRows = "'first' 1fr";

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-columns')", "'450px last'");

- shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-rows')", "'first 150px'");

+ element.style.gridDefinitionColumns = "150% (last)";

+ element.style.gridDefinitionRows = "(first) 1fr";

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-columns')", "'450px (last)'");

+ shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-rows')", "'(first) 150px'");

element.style.display = "grid";

element.style.gridDefinitionColumns = "initial";