Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt

Issue 23528004: [CSS Grid Layout] Update named grid lines syntax to the last version of the specs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@named
Patch Set: Final patch for landing Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set.html ('k') | LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js » ('j') | Source/core/css/CSSGridLineNamesValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt
diff --git a/LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt b/LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt
index 992f99ca6dc63cc9290f0797164680d8d0b0c26d..6c560906a6b80ae70950f5303df05b8e027a70ec 100644
--- a/LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt
+++ b/LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt
@@ -4,68 +4,72 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
Test getting grid-definition-columns and grid-definition-rows set through CSS
-PASS window.getComputedStyle(gridWithFixedElement, '').getPropertyValue('grid-definition-columns') is "first 10px"
-PASS window.getComputedStyle(gridWithFixedElement, '').getPropertyValue('grid-definition-rows') is "first 15px"
-PASS window.getComputedStyle(gridWithPercentElement, '').getPropertyValue('grid-definition-columns') is "53% last"
-PASS window.getComputedStyle(gridWithPercentElement, '').getPropertyValue('grid-definition-rows') is "27% last"
-PASS window.getComputedStyle(gridWithAutoElement, '').getPropertyValue('grid-definition-columns') is "first auto"
-PASS window.getComputedStyle(gridWithAutoElement, '').getPropertyValue('grid-definition-rows') is "auto last"
-PASS window.getComputedStyle(gridWithMinMax, '').getPropertyValue('grid-definition-columns') is "first minmax(10%, 15px)"
-PASS window.getComputedStyle(gridWithMinMax, '').getPropertyValue('grid-definition-rows') is "minmax(20px, 50%) last"
-PASS window.getComputedStyle(gridWithFixedMultiple, '').getPropertyValue('grid-definition-columns') is "first nav 10px last"
-PASS window.getComputedStyle(gridWithFixedMultiple, '').getPropertyValue('grid-definition-rows') is "first nav 15px last"
-PASS window.getComputedStyle(gridWithPercentageSameStringMultipleTimes, '').getPropertyValue('grid-definition-columns') is "first nav 10% nav 15% last"
-PASS window.getComputedStyle(gridWithPercentageSameStringMultipleTimes, '').getPropertyValue('grid-definition-rows') is "first nav2 25% nav2 75% last"
+PASS window.getComputedStyle(gridWithFixedElement, '').getPropertyValue('grid-definition-columns') is "(first) 10px"
+PASS window.getComputedStyle(gridWithFixedElement, '').getPropertyValue('grid-definition-rows') is "(first) 15px"
+PASS window.getComputedStyle(gridWithPercentElement, '').getPropertyValue('grid-definition-columns') is "53% (last)"
+PASS window.getComputedStyle(gridWithPercentElement, '').getPropertyValue('grid-definition-rows') is "27% (last)"
+PASS window.getComputedStyle(gridWithAutoElement, '').getPropertyValue('grid-definition-columns') is "(first) auto"
+PASS window.getComputedStyle(gridWithAutoElement, '').getPropertyValue('grid-definition-rows') is "auto (last)"
+PASS window.getComputedStyle(gridWithMinMax, '').getPropertyValue('grid-definition-columns') is "(first) minmax(10%, 15px)"
+PASS window.getComputedStyle(gridWithMinMax, '').getPropertyValue('grid-definition-rows') is "minmax(20px, 50%) (last)"
+PASS window.getComputedStyle(gridWithFixedMultiple, '').getPropertyValue('grid-definition-columns') is "(first nav) 10px (last)"
+PASS window.getComputedStyle(gridWithFixedMultiple, '').getPropertyValue('grid-definition-rows') is "(first nav) 15px (last)"
+PASS window.getComputedStyle(gridWithPercentageSameStringMultipleTimes, '').getPropertyValue('grid-definition-columns') is "(first nav) 10% (nav) 15% (last)"
+PASS window.getComputedStyle(gridWithPercentageSameStringMultipleTimes, '').getPropertyValue('grid-definition-rows') is "(first nav2) 25% (nav2) 75% (last)"
+PASS window.getComputedStyle(gridWithRepeatElement, '').getPropertyValue('grid-definition-columns') is "(first) 10px (nav nav2) 50% (nav nav2) 50%"
+PASS window.getComputedStyle(gridWithRepeatElement, '').getPropertyValue('grid-definition-rows') is "100px (nav nav2) 25% (nav nav2) 25% (last)"
+PASS window.getComputedStyle(gridWithEmptyParentheses, '').getPropertyValue('grid-definition-columns') is "10px"
+PASS window.getComputedStyle(gridWithEmptyParentheses, '').getPropertyValue('grid-definition-rows') is "20px 50px"
Test getting and setting grid-definition-columns and grid-definition-rows through JS
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first 18px"
-PASS element.style.gridDefinitionColumns is "first 18px"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "66px last"
-PASS element.style.gridDefinitionRows is "66px last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first 55%"
-PASS element.style.gridDefinitionColumns is "first 55%"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "40% last"
-PASS element.style.gridDefinitionRows is "40% last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first auto"
-PASS element.style.gridDefinitionColumns is "first auto"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "auto last"
-PASS element.style.gridDefinitionRows is "auto last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first min-content"
-PASS element.style.gridDefinitionColumns is "first min-content"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "min-content last"
-PASS element.style.gridDefinitionRows is "min-content last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first max-content"
-PASS element.style.gridDefinitionColumns is "first max-content"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "max-content last"
-PASS element.style.gridDefinitionRows is "max-content last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first minmax(55%, 45px)"
-PASS element.style.gridDefinitionColumns is "first minmax(55%, 45px)"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "minmax(30px, 40%) last"
-PASS element.style.gridDefinitionRows is "minmax(30px, 40%) last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first minmax(220px, max-content)"
-PASS element.style.gridDefinitionColumns is "first minmax(22em, max-content)"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "minmax(max-content, 50px) last"
-PASS element.style.gridDefinitionRows is "minmax(max-content, 5em) last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first minmax(220px, min-content)"
-PASS element.style.gridDefinitionColumns is "first minmax(22em, min-content)"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "minmax(min-content, 50px) last"
-PASS element.style.gridDefinitionRows is "minmax(min-content, 5em) last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first minmax(min-content, max-content)"
-PASS element.style.gridDefinitionColumns is "first minmax(min-content, max-content)"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "minmax(max-content, min-content) last"
-PASS element.style.gridDefinitionRows is "minmax(max-content, min-content) last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first nav minmax(min-content, max-content) last"
-PASS element.style.gridDefinitionColumns is "first nav minmax(min-content, max-content) last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "first nav minmax(max-content, min-content) last"
-PASS element.style.gridDefinitionRows is "first nav minmax(max-content, min-content) last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first nav minmax(min-content, max-content) nav auto last"
-PASS element.style.gridDefinitionColumns is "first nav minmax(min-content, max-content) nav auto last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "first nav2 minmax(max-content, min-content) nav2 minmax(10px, 15px) last"
-PASS element.style.gridDefinitionRows is "first nav2 minmax(max-content, min-content) nav2 minmax(10px, 15px) last"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "foo bar auto foo auto bar"
-PASS element.style.gridDefinitionColumns is "foo bar auto foo auto bar"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "foo bar auto foo auto bar"
-PASS element.style.gridDefinitionRows is "foo bar auto foo auto bar"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) 18px"
+PASS element.style.gridDefinitionColumns is "(first) 18px"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "66px (last)"
+PASS element.style.gridDefinitionRows is "66px (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) 55%"
+PASS element.style.gridDefinitionColumns is "(first) 55%"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "40% (last)"
+PASS element.style.gridDefinitionRows is "40% (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) auto"
+PASS element.style.gridDefinitionColumns is "(first) auto"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "auto (last)"
+PASS element.style.gridDefinitionRows is "auto (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) min-content"
+PASS element.style.gridDefinitionColumns is "(first) min-content"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "min-content (last)"
+PASS element.style.gridDefinitionRows is "min-content (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) max-content"
+PASS element.style.gridDefinitionColumns is "(first) max-content"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "max-content (last)"
+PASS element.style.gridDefinitionRows is "max-content (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) minmax(55%, 45px)"
+PASS element.style.gridDefinitionColumns is "(first) minmax(55%, 45px)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "minmax(30px, 40%) (last)"
+PASS element.style.gridDefinitionRows is "minmax(30px, 40%) (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) minmax(220px, max-content)"
+PASS element.style.gridDefinitionColumns is "(first) minmax(22em, max-content)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "minmax(max-content, 50px) (last)"
+PASS element.style.gridDefinitionRows is "minmax(max-content, 5em) (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) minmax(220px, min-content)"
+PASS element.style.gridDefinitionColumns is "(first) minmax(22em, min-content)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "minmax(min-content, 50px) (last)"
+PASS element.style.gridDefinitionRows is "minmax(min-content, 5em) (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first) minmax(min-content, max-content)"
+PASS element.style.gridDefinitionColumns is "(first) minmax(min-content, max-content)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "minmax(max-content, min-content) (last)"
+PASS element.style.gridDefinitionRows is "minmax(max-content, min-content) (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first nav) minmax(min-content, max-content) (last)"
+PASS element.style.gridDefinitionColumns is "(first nav) minmax(min-content, max-content) (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "(first nav) minmax(max-content, min-content) (last)"
+PASS element.style.gridDefinitionRows is "(first nav) minmax(max-content, min-content) (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(first nav) minmax(min-content, max-content) (nav) auto (last)"
+PASS element.style.gridDefinitionColumns is "(first nav) minmax(min-content, max-content) (nav) auto (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "(first nav2) minmax(max-content, min-content) (nav2) minmax(10px, 15px) (last)"
+PASS element.style.gridDefinitionRows is "(first nav2) minmax(max-content, min-content) (nav2) minmax(10px, 15px) (last)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "(foo bar) auto (foo) auto (bar)"
+PASS element.style.gridDefinitionColumns is "(foo bar) auto (foo) auto (bar)"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "(foo bar) auto (foo) auto (bar)"
+PASS element.style.gridDefinitionRows is "(foo bar) auto (foo) auto (bar)"
Test getting and setting invalid grid-definition-columns and grid-definition-rows through JS
PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
« LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set.html ('k') | LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js » ('j') | Source/core/css/CSSGridLineNamesValue.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698