Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

This patch also removes the Editor::firstRectForRange(const Range*)
overload because it has no call site.

BUG=647219
Committed: https://crrev.com/6764bd685aec4e5ee0b159c358ab63ebd0591c27
Cr-Commit-Position: refs/heads/master@{#420602}

[Xiaocheng, 2016-09-20 03:41:57]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 03:42:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 04:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 04:19:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-09-20 12:03:07]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 12:03:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 13:07:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-09-23 01:17:07]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 01:17:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-23 02:09:49]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 02:10:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-23 02:56:11]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-09-23 02:56:43]

PTAL.

[commit-bot: I haz the power, 2016-09-23 03:30:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:30:19]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-09-23 05:32:14]

https://codereview.chromium.org/2352763004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.h (left):

https://codereview.chromium.org/2352763004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.h:221: IntRect
firstRectForRange(const Range*) const;
Please mention this removal in the CL description.

https://codereview.chromium.org/2352763004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.h (right):

https://codereview.chromium.org/2352763004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.h:220: IntRect
firstRectForRange(const EphemeralRange&) const;
Now this function assumes up-to-date layout.  We should add a comment about it
to Editor.h, add DisallowTransitionScope to firstRectForRange(), add
DHECK(...frameView()->needsLayotu()) to firstRectForRange(), and/or add
DCHECK(...document().needsLayoutTreeUpdate()) to firstRectForRange().
We should have a consistent policy about how to enforce the assumption.

[Xiaocheng, 2016-09-23 05:35:34]

Description was changed from

==========
Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

BUG=647219
==========

to

==========
Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

This patch also removes the Editor::firstRectForRange(const Range*)
overload because it has no call site.

BUG=647219
==========

[Xiaocheng, 2016-09-23 05:53:24]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 05:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-23 05:54:44]

Updated. PTAL.

https://codereview.chromium.org/2352763004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.h (left):

https://codereview.chromium.org/2352763004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.h:221: IntRect
firstRectForRange(const Range*) const;
On 2016/09/23 at 05:32:14, tkent wrote:
> Please mention this removal in the CL description.

Done.

https://codereview.chromium.org/2352763004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.h (right):

https://codereview.chromium.org/2352763004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.h:220: IntRect
firstRectForRange(const EphemeralRange&) const;
On 2016/09/23 at 05:32:14, tkent wrote:
> Now this function assumes up-to-date layout.  We should add a comment about it
to Editor.h, add DisallowTransitionScope to firstRectForRange(), add
DHECK(...frameView()->needsLayotu()) to firstRectForRange(), and/or add
DCHECK(...document().needsLayoutTreeUpdate()) to firstRectForRange().

Done.

> We should have a consistent policy about how to enforce the assumption.

Yeah, we should...

[tkent, 2016-09-23 07:14:51]

lgtm

[commit-bot: I haz the power, 2016-09-23 07:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 07:25:18]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-23 10:02:13]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-09-23 10:02:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 11:39:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-23 11:43:28]

Description was changed from

==========
Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

This patch also removes the Editor::firstRectForRange(const Range*)
overload because it has no call site.

BUG=647219
==========

to

==========
Prune CreateVisiblePositionDeprecated from Editor::firstRectForRange

This patch also removes the Editor::firstRectForRange(const Range*)
overload because it has no call site.

BUG=647219

Committed: https://crrev.com/6764bd685aec4e5ee0b159c358ab63ebd0591c27
Cr-Commit-Position: refs/heads/master@{#420602}
==========

[commit-bot: I haz the power, 2016-09-23 11:43:29]

Patchset 5 (id:??) landed as
https://crrev.com/6764bd685aec4e5ee0b159c358ab63ebd0591c27
Cr-Commit-Position: refs/heads/master@{#420602}