Issue 23526069: Refactor back edge table related code into a new class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23526069: Refactor back edge table related code into a new class. (Closed)

Created:
7 years, 3 months ago by Yang

Modified:
7 years, 3 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactor back edge table related code into a new class. This is mostly moving and renaming, except for the BackEdgeTableIterator. Motivation is that the back edges in unoptimized code has nothing to do with the deoptimizer. R=titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16815

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+513 lines, -529 lines)			Patch
M	src/arm/deoptimizer-arm.cc	View	1 chunk	+0 lines, -94 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 chunk	+95 lines, -0 lines	0 comments	Download
M	src/deoptimizer.h	View	2 chunks	+0 lines, -38 lines	0 comments	Download
M	src/deoptimizer.cc	View	1 chunk	+0 lines, -79 lines	0 comments	Download
M	src/full-codegen.h	View	2 chunks	+85 lines, -59 lines	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+73 lines, -0 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	1 chunk	+0 lines, -81 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+82 lines, -0 lines	0 comments	Download
M	src/mips/deoptimizer-mips.cc	View	1 chunk	+0 lines, -82 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 chunk	+83 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	2 chunks	+9 lines, -10 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/runtime-profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1 chunk	+0 lines, -81 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+82 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

titzer

LGTM. Glad to have this functionality out of the deoptimizer.

7 years, 3 months ago (2013-09-19 08:55:41 UTC) #2

Yang

7 years, 3 months ago (2013-09-19 09:08:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16815 (presubmit successful).

Expand Messages | Collapse Messages