Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp - Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp ('K') | « Source/bindings/v8/custom/V8WindowCustom.cpp ('k') | Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

diff --git a/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp b/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

index eb0f4a1b84f0a61796546b57faf9e79911e85527..fca0437473e002deabdd613ae6dcdaad60eafdc2 100644

--- a/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

+++ b/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

@@ -172,8 +172,8 @@ void V8XMLHttpRequest::openMethodCustom(const v8::FunctionCallbackInfo<v8::Value

XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toNative(args.Holder());

- String method = toWebCoreString(args[0]);

- String urlstring = toWebCoreString(args[1]);

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, method, args[0]);

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, urlstring, args[1]);

ScriptExecutionContext* context = getScriptExecutionContext();

KURL url = context->completeURL(urlstring);