Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp - Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp

Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp ('K') | « Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp b/Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp

index afeade82bd522a4a34e0f1a0973778edd870928c..5641961c54c75109b0c24f9db53d71d1f251f60b 100644

--- a/Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp

@@ -60,8 +60,10 @@ namespace WebCore {

static String writeHelperGetString(const v8::FunctionCallbackInfo<v8::Value>& args)

{

StringBuilder builder;

- for (int i = 0; i < args.Length(); ++i)

- builder.append(toWebCoreString(args[i]));

+ for (int i = 0; i < args.Length(); ++i) {

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<>, stringArgument, args[i], String());

haraken 2013/09/12 17:33:52 Ditto.

+ builder.append(stringArgument);

+ }

return builder.toString();

}