Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp - Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp ('K') | « Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

index 2f73bff9ec80ee6c7e245880b4b5ee71cfcd1a65..22658c3dd0577b4b4ce1b958bbc50d760b656d47 100644

--- a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

@@ -65,8 +65,9 @@ static void getNamedItems(HTMLOptionsCollection* collection, const AtomicString&

void V8HTMLOptionsCollection::namedItemMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)

{

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, name, args[0]);

HTMLOptionsCollection* imp = V8HTMLOptionsCollection::toNative(args.Holder());

- getNamedItems(imp, toWebCoreString(args[0]), args);

+ getNamedItems(imp, name, args);

}

void V8HTMLOptionsCollection::addMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)