Source/bindings/v8/custom/V8DocumentLocationCustom.cpp - Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8DocumentLocationCustom.cpp

Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/V8Binding.h ('K') | « Source/bindings/v8/custom/V8DocumentCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp » ('j') | Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8DocumentLocationCustom.cpp

diff --git a/Source/bindings/v8/custom/V8DocumentLocationCustom.cpp b/Source/bindings/v8/custom/V8DocumentLocationCustom.cpp

index a913ba0d79bdb10d26e35177a44eb9ac0ade4184..c9b98ef13c99b5f3f27bc6612e0f03e616d28880 100644

--- a/Source/bindings/v8/custom/V8DocumentLocationCustom.cpp

+++ b/Source/bindings/v8/custom/V8DocumentLocationCustom.cpp

@@ -58,8 +58,10 @@ void V8Document::locationAttributeSetterCustom(v8::Local<v8::String> name, v8::L

return;

DOMWindow* window = document->domWindow();

- if (Location* location = window->location())

- location->setHref(active, first, toWebCoreString(value));

+ if (Location* location = window->location()) {

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, stringValue, value);

+ location->setHref(active, first, stringValue);

+ }

}

} // namespace WebCore