Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8Binding.h
diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h
index 723840b2b8b762e44993139900967594246186c5..1751f43c6d125d6d74b3df3781dfa071f6e75fff 100644
--- a/Source/bindings/v8/V8Binding.h
+++ b/Source/bindings/v8/V8Binding.h
@@ -391,7 +391,8 @@ namespace WebCore {
struct NativeValueTraits<String> {
static inline String nativeValue(const v8::Handle<v8::Value>& value)
{
- return toWebCoreString(value);
+ V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<>, stringValue, value, String());
haraken 2013/09/12 17:33:52 This change wouldn't be helpful until you fix all
do-not-use 2013/09/13 14:55:49 The reason I used V8TRYCATCH_FOR_V8STRINGRESOURCE_
+ return stringValue;
}
};
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8DocumentCustom.cpp » ('j') | Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698