Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2352443002: [Documentation] Resolve mismatched Javadoc comments in LoadUrlParams. (Closed)

Created:
4 years, 3 months ago by Raveendra Karu
Modified:
3 years, 6 months ago
Reviewers:
Pritam Nikam, Srirama, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Documentation] Resolve mismatched Javadoc comments in LoadUrlParams. Javadoc comments of getReferrer() and setReferrer() APIs are mismatched. Resolved the mismatched comments. Review-Url: https://codereview.chromium.org/2352443002 Cr-Commit-Position: refs/heads/master@{#476720} Committed: https://chromium.googlesource.com/chromium/src/+/4ee29d84f1e2b2c9df708639e0740be38278f91a

Patch Set 1 #

Patch Set 2 : Rebasing the patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Srirama
Peer review looks good to me.
4 years, 3 months ago (2016-09-17 05:12:18 UTC) #3
Pritam Nikam
Hi darin@. Corrected documentation. Please review changes. Thanks!
4 years, 3 months ago (2016-09-17 05:30:16 UTC) #5
Srirama
boliu@chromium.org: Please review
3 years, 6 months ago (2017-06-02 05:39:50 UTC) #8
boliu
lgtm
3 years, 6 months ago (2017-06-02 16:21:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352443002/20001
3 years, 6 months ago (2017-06-02 18:02:00 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 18:07:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ee29d84f1e2b2c9df708639e074...

Powered by Google App Engine
This is Rietveld 408576698