Add more use counters for document.createTouch

Add more use counters for document.createTouch

Safari has 7 required arguments for document.createTouch and treats the
first two arguments as nullable. The hoped-for outcome is that Blink
can also have 7 required arguments, but that at least the target argument
is non-nullable. If not, Touch.prototype.target must be made nullable too.

BUG=647693
R=rbyers@chromium.org

Committed: https://crrev.com/738daed0f742e6bc5f35b0fa895990144dd37010
Cr-Commit-Position: refs/heads/master@{#422071}

[foolip, 2016-09-21 09:40:07]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 09:40:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 10:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 10:59:06]

Dry run: This issue passed the CQ dry run.

[Rick Byers, 2016-09-26 18:59:45]

LGTM

FWIW this may be overkill.  We've already successfully removed initTouchEvent
(https://bugs.chromium.org/p/chromium/issues/detail?id=522100) so we can
probably safely change (and ultimately remove) createTouch as well.

According to https://bugs.webkit.org/show_bug.cgi?id=147740 webkit now supports
the standard constructors.  Maybe there's a bug still?

[foolip, 2016-09-30 07:59:01]

On 2016/09/26 18:59:45, Rick Byers wrote:
> LGTM
> 
> FWIW this may be overkill.  We've already successfully removed initTouchEvent
> (https://bugs.chromium.org/p/chromium/issues/detail?id=522100) so we can
> probably safely change (and ultimately remove) createTouch as well.

Maybe, but createTouch is more interoperable than initTouchEvent was, although I
don't know if it was ever useful. Use counters will tell.

> According to https://bugs.webkit.org/show_bug.cgi?id=147740 webkit now
supports
> the standard constructors.  Maybe there's a bug still?

Maybe discussion happened after you posted this comment, but it looks like the
issue is open and it's not implemented?

Nevertheless, I'm going to back out the Touch constructor changes in favor of
issue 651660 and just land the createTouch bits.

[foolip, 2016-09-30 08:01:15]

On 2016/09/30 07:59:01, foolip wrote:
> On 2016/09/26 18:59:45, Rick Byers wrote:
> > LGTM
> > 
> > FWIW this may be overkill.  We've already successfully removed
initTouchEvent
> > (https://bugs.chromium.org/p/chromium/issues/detail?id=522100) so we can
> > probably safely change (and ultimately remove) createTouch as well.
> 
> Maybe, but createTouch is more interoperable than initTouchEvent was, although
I
> don't know if it was ever useful. Use counters will tell.

Oh right, we already have one, not looking great:
https://www.chromestatus.com/metrics/feature/timeline/popularity/874

[foolip, 2016-09-30 08:08:32]

Description was changed from

==========
Add use counters for new Touch and document.createTouch

Safari has 7 required arguments for document.createTouch, and
apparently the same arguments for the Touch constructor.

Possible outcomes in order of preference:

 * TouchInit's target (already required) becomes non-nullable, and
   document.createTouch gets 7 required non-nullable arguments with
   strict type checking.
 * The arguments for new Touch and document.createTouch all become
   optional and nullable, but with strict type checking.
 * The *WrongType use counters are too high, so `any` must be used for
   document.createTouch's first two arguments to match
   [LegacyInterfaceTypeChecking], and TouchInit is made optional.

None of the above would get us interop for the Touch constructor, that
will require a broader discussion.

BUG=647693
R=rbyers@chromium.org
==========

to

==========
Add more use counters for document.createTouch

Safari has 7 required arguments for document.createTouch and treats the
first two arguments as nullable. The hoped-for outcome is that Blink
can also have 7 required arguments, but that at least the target argument
is non-nullable. If not, Touch.prototype.target must be made nullable too.

BUG=647693
R=rbyers@chromium.org
==========

[foolip, 2016-09-30 08:10:29]

Description was changed from

==========
Add more use counters for document.createTouch

Safari has 7 required arguments for document.createTouch and treats the
first two arguments as nullable. The hoped-for outcome is that Blink
can also have 7 required arguments, but that at least the target argument
is non-nullable. If not, Touch.prototype.target must be made nullable too.

BUG=647693
R=rbyers@chromium.org
==========

to

==========
Add more use counters for document.createTouch

Safari has 7 required arguments for document.createTouch and treats the
first two arguments as nullable. The hoped-for outcome is that Blink
can also have 7 required arguments, but that at least the target argument
is non-nullable. If not, Touch.prototype.target must be made nullable too.

BUG=647693
R=rbyers@chromium.org
==========

[foolip, 2016-09-30 08:10:33]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-09-30 08:10:34]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2352333002/#ps20001
(title: "back out Touch changes")

[commit-bot: I haz the power, 2016-09-30 08:10:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 08:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 08:20:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mike West, 2016-09-30 08:37:27]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-09-30 08:37:28]

histograms.xml LGTM

[foolip, 2016-09-30 08:38:05]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-09-30 08:38:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 09:32:27]

Description was changed from

==========
Add more use counters for document.createTouch

Safari has 7 required arguments for document.createTouch and treats the
first two arguments as nullable. The hoped-for outcome is that Blink
can also have 7 required arguments, but that at least the target argument
is non-nullable. If not, Touch.prototype.target must be made nullable too.

BUG=647693
R=rbyers@chromium.org
==========

to

==========
Add more use counters for document.createTouch

Safari has 7 required arguments for document.createTouch and treats the
first two arguments as nullable. The hoped-for outcome is that Blink
can also have 7 required arguments, but that at least the target argument
is non-nullable. If not, Touch.prototype.target must be made nullable too.

BUG=647693
R=rbyers@chromium.org
==========

[commit-bot: I haz the power, 2016-09-30 09:32:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 09:33:45]

Description was changed from

==========
Add more use counters for document.createTouch

Safari has 7 required arguments for document.createTouch and treats the
first two arguments as nullable. The hoped-for outcome is that Blink
can also have 7 required arguments, but that at least the target argument
is non-nullable. If not, Touch.prototype.target must be made nullable too.

BUG=647693
R=rbyers@chromium.org
==========

to

==========
Add more use counters for document.createTouch

Safari has 7 required arguments for document.createTouch and treats the
first two arguments as nullable. The hoped-for outcome is that Blink
can also have 7 required arguments, but that at least the target argument
is non-nullable. If not, Touch.prototype.target must be made nullable too.

BUG=647693
R=rbyers@chromium.org

Committed: https://crrev.com/738daed0f742e6bc5f35b0fa895990144dd37010
Cr-Commit-Position: refs/heads/master@{#422071}
==========

[commit-bot: I haz the power, 2016-09-30 09:33:46]

Patchset 2 (id:??) landed as
https://crrev.com/738daed0f742e6bc5f35b0fa895990144dd37010
Cr-Commit-Position: refs/heads/master@{#422071}