third_party/WebKit/Source/core/dom/Document.cpp - Issue 2352333002: Add more use counters for document.createTouch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2352333002: Add more use counters for document.createTouch (Closed)

Patch Set: back out Touch changes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('k') | third_party/WebKit/Source/core/dom/Document.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index d7947014be21f8f85fd63fe3e2ce07c9e86a90f7..eee018daa1c7a4f3c3a30fdbb2198a8fdf15497c 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -5521,6 +5521,9 @@ Touch* Document::createTouch(DOMWindow* window, EventTarget* target, int identif

if (!std::isfinite(force))

force = 0;

+ if (radiusX || radiusY || rotationAngle || force)

+ UseCounter::count(*this, UseCounter::DocumentCreateTouchMoreThanSevenArguments);

// FIXME: It's not clear from the documentation at

// http://developer.apple.com/library/safari/#documentation/UserExperience/Reference/DocumentAdditionsReference/DocumentAdditions/DocumentAdditions.html

// when this method should throw and nor is it by inspection of iOS behavior. It would be nice to verify any cases where it throws under iOS