Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 23523034: Replace uses of MUST_USE_RESULT by V8_WARN_UNUSED_RESULT in ElapsedTimer. (Closed)

Created:
7 years, 3 months ago by tfarina
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Replace uses of MUST_USE_RESULT by V8_WARN_UNUSED_RESULT in ElapsedTimer. R=bmeurer@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: https://code.google.com/p/v8/source/detail?r=16583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/platform/elapsed-timer.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Is this fine? I know it is a one-off, so it might not be accepted. ...
7 years, 3 months ago (2013-09-07 04:12:25 UTC) #1
Benedikt Meurer
LGTM, will land.
7 years, 3 months ago (2013-09-09 05:42:17 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-09-09 05:45:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698