Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: src/platform/elapsed-timer.h

Issue 23523034: Replace uses of MUST_USE_RESULT by V8_WARN_UNUSED_RESULT in ElapsedTimer. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 TimeTicks ticks = Now(); 80 TimeTicks ticks = Now();
81 TimeDelta elapsed = ticks - start_ticks_; 81 TimeDelta elapsed = ticks - start_ticks_;
82 ASSERT(elapsed.InMicroseconds() >= 0); 82 ASSERT(elapsed.InMicroseconds() >= 0);
83 start_ticks_ = ticks; 83 start_ticks_ = ticks;
84 ASSERT(IsStarted()); 84 ASSERT(IsStarted());
85 return elapsed; 85 return elapsed;
86 } 86 }
87 87
88 // Returns the time elapsed since the previous start. This method may only 88 // Returns the time elapsed since the previous start. This method may only
89 // be called on a previously started timer. 89 // be called on a previously started timer.
90 MUST_USE_RESULT TimeDelta Elapsed() const { 90 TimeDelta Elapsed() const V8_WARN_UNUSED_RESULT {
91 ASSERT(IsStarted()); 91 ASSERT(IsStarted());
92 TimeDelta elapsed = Now() - start_ticks_; 92 TimeDelta elapsed = Now() - start_ticks_;
93 ASSERT(elapsed.InMicroseconds() >= 0); 93 ASSERT(elapsed.InMicroseconds() >= 0);
94 return elapsed; 94 return elapsed;
95 } 95 }
96 96
97 // Returns |true| if the specified |time_delta| has elapsed since the 97 // Returns |true| if the specified |time_delta| has elapsed since the
98 // previous start, or |false| if not. This method may only be called on 98 // previous start, or |false| if not. This method may only be called on
99 // a previously started timer. 99 // a previously started timer.
100 MUST_USE_RESULT bool HasExpired(TimeDelta time_delta) const { 100 bool HasExpired(TimeDelta time_delta) const V8_WARN_UNUSED_RESULT {
101 ASSERT(IsStarted()); 101 ASSERT(IsStarted());
102 return Elapsed() >= time_delta; 102 return Elapsed() >= time_delta;
103 } 103 }
104 104
105 private: 105 private:
106 MUST_USE_RESULT V8_INLINE(static TimeTicks Now()) { 106 V8_INLINE(static TimeTicks Now()) V8_WARN_UNUSED_RESULT {
107 TimeTicks now = TimeTicks::HighResNow(); 107 TimeTicks now = TimeTicks::HighResNow();
108 ASSERT(!now.IsNull()); 108 ASSERT(!now.IsNull());
109 return now; 109 return now;
110 } 110 }
111 111
112 TimeTicks start_ticks_; 112 TimeTicks start_ticks_;
113 #ifdef DEBUG 113 #ifdef DEBUG
114 bool started_; 114 bool started_;
115 #endif 115 #endif
116 }; 116 };
117 117
118 } } // namespace v8::internal 118 } } // namespace v8::internal
119 119
120 #endif // V8_PLATFORM_ELAPSED_TIMER_H_ 120 #endif // V8_PLATFORM_ELAPSED_TIMER_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698