Issue 23522063: Turn on i18n support by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23522063: Turn on i18n support by default (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 3 months ago

Reviewers:
Michael Starzinger, Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Turn on i18n support by default This reverts commit r16789 BUG=none R=machenbach@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16827

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -13 lines)			Patch
M	Makefile	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	Makefile.nacl	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/features.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/standalone.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/samples.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/d8.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mozilla/mozilla.status	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/test262/test262.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	tools/run-tests.py	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

+mstarzinger, can you plz give an owner-rubberstamp?

7 years, 3 months ago (2013-09-19 11:21:40 UTC) #3

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r16827.

7 years, 3 months ago (2013-09-19 12:07:16 UTC) #5

ulan

7 years, 3 months ago (2013-09-20 08:53:26 UTC) #6

Message was sent while issue was closed.

On 2013/09/19 12:07:16, jochen wrote:
> Committed patchset #1 manually as r16827.

This broke arm hard-float builds:

CXX=arm-linux-gnueabihf-g++ LINK=arm-linux-gnueabihf-g++ make arm.release -j16
hardfp=on

cc1: error: unrecognized command line option ‘-mfloat-abi=hard’
make[1]: ***
[v8/out/arm.release/obj.target/icui18n/third_party/icu/source/i18n/bocsu.o]
Error 1

Expand Messages | Collapse Messages