Makefile - Issue 23522063: Turn on i18n support by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile

Issue 23522063: Turn on i18n support by default (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Makefile

diff --git a/Makefile b/Makefile

index 288c257396de19895d85a6d399c520e939d5cb02..bcf3bcca0d11c906be7e829ef66f6c7ed850db6d 100644

--- a/Makefile

+++ b/Makefile

@@ -124,9 +124,10 @@ endif

ifeq ($(regexp), interpreted)

GYPFLAGS += -Dv8_interpreted_regexp=1

endif

-# i18nsupport=on

-ifeq ($(i18nsupport), on)

- GYPFLAGS += -Dv8_enable_i18n_support=1

+# i18nsupport=off

+ifeq ($(i18nsupport), off)

+ GYPFLAGS += -Dv8_enable_i18n_support=0

+ TESTFLAGS += --noi18n

endif

# arm specific flags.

# armv7=false/true

@@ -331,7 +332,7 @@ $(addsuffix .check, $(ANDROID_ARCHES)): \

$(addsuffix .check, $(NACL_BUILDS)): $$(basename $$@)

@tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR) \

--arch-and-mode=$(basename $@) \

- --timeout=600 --nopresubmit \

+ --timeout=600 --nopresubmit --noi18n \

--command-prefix="tools/nacl-run.py"

$(addsuffix .check, $(NACL_ARCHES)): \

« no previous file with comments | « no previous file | Makefile.nacl » ('j') | no next file with comments »