Provide Shill Error to failure notification

Provide Shill Error to failure notification

The Service.Error property is getting cleared before the notification is
displayed; we need to pass it to the notification when we detect the
error. (ErrorDetails should not be getting cleared).

BUG=291370
R=armansito@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223349

[armansito, 2013-09-14 01:13:12]

lgtm with one comment.

https://codereview.chromium.org/23522050/diff/1/ash/system/chromeos/network/n...
File ash/system/chromeos/network/network_connect.cc (right):

https://codereview.chromium.org/23522050/diff/1/ash/system/chromeos/network/n...
ash/system/chromeos/network/network_connect.cc:172:
NetworkConnectionHandler::kErrorConfigureFailed, "", "");
You may want to always check the contents of |error_data| instead of assigning
an empty string, as shill might have set the error.

[stevenjb, 2013-09-16 16:37:27]

Committed patchset #2 manually as r223349 (presubmit successful).

[stevenjb, 2013-09-16 16:38:07]

https://codereview.chromium.org/23522050/diff/1/ash/system/chromeos/network/n...
File ash/system/chromeos/network/network_connect.cc (right):

https://codereview.chromium.org/23522050/diff/1/ash/system/chromeos/network/n...
ash/system/chromeos/network/network_connect.cc:172:
NetworkConnectionHandler::kErrorConfigureFailed, "", "");
On 2013/09/14 01:13:12, armansito wrote:
> You may want to always check the contents of |error_data| instead of assigning
> an empty string, as shill might have set the error.

This still needs a re-factoring / cleanup pass, but right now if 'error_name' ==
"kErrorConfigureFailed", 'shill_error' will be ignored.

[armansito, 2013-09-16 19:24:00]

https://codereview.chromium.org/23522050/diff/1/ash/system/chromeos/network/n...
File ash/system/chromeos/network/network_connect.cc (right):

https://codereview.chromium.org/23522050/diff/1/ash/system/chromeos/network/n...
ash/system/chromeos/network/network_connect.cc:172:
NetworkConnectionHandler::kErrorConfigureFailed, "", "");
On 2013/09/16 16:38:07, stevenjb wrote:
> On 2013/09/14 01:13:12, armansito wrote:
> > You may want to always check the contents of |error_data| instead of
assigning
> > an empty string, as shill might have set the error.
> 
> This still needs a re-factoring / cleanup pass, but right now if 'error_name'
==
> "kErrorConfigureFailed", 'shill_error' will be ignored.

sgtm