Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: ash/system/chromeos/network/network_state_notifier.h

Issue 23522050: Provide Shill Error to failure notification (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/chromeos/network/network_state_notifier.h
diff --git a/ash/system/chromeos/network/network_state_notifier.h b/ash/system/chromeos/network/network_state_notifier.h
index 612dfbfb1acb1f2cf432a43d3d6ac352c2fbb0c2..1a835bbbe9ba33f89dd19a2d4d98feff1066d077 100644
--- a/ash/system/chromeos/network/network_state_notifier.h
+++ b/ash/system/chromeos/network/network_state_notifier.h
@@ -46,24 +46,28 @@ class ASH_EXPORT NetworkStateNotifier :
// Show a connection error notification. If |error_name| matches an error
// defined in NetworkConnectionHandler for connect, configure, or activation
- // failed, then the associated message is shown, otherwise the Shill
- // error for Service.Error is used (from network_connect::ErrorString), or
- // "Unknown network error".
+ // failed, then the associated message is shown, otherwise |shill_error|
+ // is expected to contain Service.Error (which might get cleared before
+ // GetProperties returns).
void ShowNetworkConnectError(const std::string& error_name,
+ const std::string& shill_error,
const std::string& service_path);
private:
void ConnectErrorPropertiesSucceeded(
const std::string& error_name,
+ const std::string& shill_error,
const std::string& service_path,
const base::DictionaryValue& shill_properties);
void ConnectErrorPropertiesFailed(
const std::string& error_name,
+ const std::string& shill_error,
const std::string& service_path,
- const std::string& shill_error_name,
+ const std::string& shill_connect_error,
scoped_ptr<base::DictionaryValue> shill_error_data);
void ShowConnectErrorNotification(
const std::string& error_name,
+ const std::string& shill_error,
const std::string& service_path,
const base::DictionaryValue& shill_properties);
« no previous file with comments | « ash/system/chromeos/network/network_connect.cc ('k') | ash/system/chromeos/network/network_state_notifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698