Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2352073003: [Offline pages] Moving static private methods from RQStoreSQL interface (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Moving static private methods from RQStoreSQL interface BUG=645522 Committed: https://crrev.com/e80d4071d5ae6ab62bfcc85164694beff7cdd357 Cr-Commit-Position: refs/heads/master@{#419906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -95 lines) Patch
M components/offline_pages/background/request_queue_store_sql.h View 1 chunk +0 lines, -34 lines 0 comments Download
M components/offline_pages/background/request_queue_store_sql.cc View 12 chunks +50 lines, -61 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
fgorski
PTAL. This only moves methods around.
4 years, 3 months ago (2016-09-20 20:01:58 UTC) #4
Pete Williamson
Looks fine, but why make the change? The methods seem OK where they are, is ...
4 years, 3 months ago (2016-09-20 20:14:41 UTC) #5
fgorski
On 2016/09/20 20:14:41, Pete Williamson wrote: > Looks fine, but why make the change? The ...
4 years, 3 months ago (2016-09-20 20:26:52 UTC) #8
Pete Williamson
lgtm
4 years, 3 months ago (2016-09-20 23:11:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352073003/1
4 years, 3 months ago (2016-09-20 23:13:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 00:05:17 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 00:10:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e80d4071d5ae6ab62bfcc85164694beff7cdd357
Cr-Commit-Position: refs/heads/master@{#419906}

Powered by Google App Engine
This is Rietveld 408576698