[Offline pages] Moving static private methods from RQStoreSQL interface

[Offline pages] Moving static private methods from RQStoreSQL interface

BUG=645522
Committed: https://crrev.com/e80d4071d5ae6ab62bfcc85164694beff7cdd357
Cr-Commit-Position: refs/heads/master@{#419906}

[fgorski, 2016-09-20 20:00:02]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:00:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-09-20 20:01:57]

fgorski@chromium.org changed reviewers:
+ petewil@chromium.org

[fgorski, 2016-09-20 20:01:58]

PTAL. This only moves methods around.

[Pete Williamson, 2016-09-20 20:14:41]

Looks fine, but why make the change?  The methods seem OK where they are,
is this part one of a larger refactoring?

On Tue, Sep 20, 2016 at 1:01 PM, <fgorski@chromium.org> wrote:

> Reviewers: Pete Williamson
> CL: https://codereview.chromium.org/2352073003/
>
> Message:
> PTAL. This only moves methods around.
>
> Description:
> [Offline pages] Moving static private methods from RQStoreSQL interface
>
> BUG=645522
>
> Affected files (+50, -95 lines):
> M components/offline_pages/background/request_queue_store_sql.h
> M components/offline_pages/background/request_queue_store_sql.cc
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-09-20 20:25:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:25:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[fgorski, 2016-09-20 20:26:52]

On 2016/09/20 20:14:41, Pete Williamson wrote:
> Looks fine, but why make the change?  The methods seem OK where they are,
> is this part one of a larger refactoring?

https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_a...

And yes, I am looking at request_queue_store_sql now for the refactoring effort.

> 
> On Tue, Sep 20, 2016 at 1:01 PM, <mailto:fgorski@chromium.org> wrote:
> 
> > Reviewers: Pete Williamson
> > CL: https://codereview.chromium.org/2352073003/
> >
> > Message:
> > PTAL. This only moves methods around.
> >
> > Description:
> > [Offline pages] Moving static private methods from RQStoreSQL interface
> >
> > BUG=645522
> >
> > Affected files (+50, -95 lines):
> > M components/offline_pages/background/request_queue_store_sql.h
> > M components/offline_pages/background/request_queue_store_sql.cc
> >
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Pete Williamson, 2016-09-20 23:11:10]

lgtm

[fgorski, 2016-09-20 23:12:57]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-09-20 23:13:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:05:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 00:10:55]

Description was changed from

==========
[Offline pages] Moving static private methods from RQStoreSQL interface

BUG=645522
==========

to

==========
[Offline pages] Moving static private methods from RQStoreSQL interface

BUG=645522

Committed: https://crrev.com/e80d4071d5ae6ab62bfcc85164694beff7cdd357
Cr-Commit-Position: refs/heads/master@{#419906}
==========

[commit-bot: I haz the power, 2016-09-21 00:10:56]

Patchset 1 (id:??) landed as
https://crrev.com/e80d4071d5ae6ab62bfcc85164694beff7cdd357
Cr-Commit-Position: refs/heads/master@{#419906}