Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: components/offline_pages/background/request_queue_store_sql.h

Issue 2352073003: [Offline pages] Moving static private methods from RQStoreSQL interface (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/background/request_queue_store_sql.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/request_queue_store_sql.h
diff --git a/components/offline_pages/background/request_queue_store_sql.h b/components/offline_pages/background/request_queue_store_sql.h
index 3e8e0b963ed614881cd9c377f6fb3c8a5e0c9ecd..158341372404e6e5f92f9c266afc1de7c3d282b6 100644
--- a/components/offline_pages/background/request_queue_store_sql.h
+++ b/components/offline_pages/background/request_queue_store_sql.h
@@ -45,44 +45,10 @@ class RequestQueueStoreSQL : public RequestQueueStore {
void Reset(const ResetCallback& callback) override;
private:
- // Synchronous implementations, these are run on the background thread
- // and actually do the work to access SQL. The implementations above
- // simply dispatch to the corresponding *Sync method on the background thread.
- // 'runner' is where to run the callback.
- static void GetRequestsSync(
- sql::Connection* db,
- scoped_refptr<base::SingleThreadTaskRunner> runner,
- const GetRequestsCallback& callback);
- static void AddOrUpdateRequestSync(
- sql::Connection* db,
- scoped_refptr<base::SingleThreadTaskRunner> runner,
- const SavePageRequest& offline_page,
- const UpdateCallback& callback);
- static void RemoveRequestsSync(
- sql::Connection* db,
- scoped_refptr<base::SingleThreadTaskRunner> runner,
- const std::vector<int64_t>& request_ids,
- const RemoveCallback& callback);
- static void ChangeRequestsStateSync(
- sql::Connection* db,
- scoped_refptr<base::SingleThreadTaskRunner> runner,
- const std::vector<int64_t>& request_ids,
- const SavePageRequest::RequestState new_state,
- const UpdateMultipleRequestsCallback& callback);
- static void ResetSync(sql::Connection* db,
- const base::FilePath& db_file_path,
- scoped_refptr<base::SingleThreadTaskRunner> runner,
- const ResetCallback& callback);
-
// Helper functions to return immediately if no database is found.
bool CheckDb(const base::Closure& callback);
// Used to initialize DB connection.
- static void OpenConnectionSync(
- sql::Connection* db,
- scoped_refptr<base::SingleThreadTaskRunner> runner,
- const base::FilePath& path,
- const base::Callback<void(bool)>& callback);
void OpenConnection();
void OnOpenConnectionDone(bool success);
« no previous file with comments | « no previous file | components/offline_pages/background/request_queue_store_sql.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698