Clean up UMA 3g experiment and unify metrics enabled pref for Android

components/metrics/net/cellular_logic_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/net/cellular_logic_helper.h"
 
-#include "components/variations/variations_associated_data.h"
 #include "net/base/network_change_notifier.h"
 
 namespace metrics {
 
 namespace {
 
 // Standard interval between log uploads, in seconds.
 #if defined(OS_ANDROID) || defined(OS_IOS)
 const int kStandardUploadIntervalSeconds = 5 * 60;           // Five minutes.
 const int kStandardUploadIntervalCellularSeconds = 15 * 60;  // Fifteen minutes.
 #else
 const int kStandardUploadIntervalSeconds = 30 * 60;  // Thirty minutes.
 #endif
 
-#if defined(OS_ANDROID)
-const bool kDefaultCellularLogicEnabled = true;
-const bool kDefaultCellularLogicOptimization = true;
-#else
-const bool kDefaultCellularLogicEnabled = false;
-const bool kDefaultCellularLogicOptimization = false;
-#endif

[Alexei Svitkine (slow), 2016/09/19 19:38:02]

Shouldn't we keep this logic - given that we still only want to enable it on
Android and not other platforms for now?

[gayane -on leave until 09-2017, 2016/09/19 20:05:58]

Brought back the defaults but still removed the experiment code. 
Should I also get ride of kDefaultCellularLogicOptimization which we introduced
very early in experiments but it was never really useful 

[Alexei Svitkine (slow), 2016/09/19 20:36:56]

Given that in this file the extra boolean is not doing anything that the first
boolean isn't doing, I think it's fine to remove here and just use the one
boolean.

-
 }  // namespace
 
 base::TimeDelta GetUploadInterval() {
 #if defined(OS_ANDROID) || defined(OS_IOS)
   if (IsCellularLogicEnabled())
     return base::TimeDelta::FromSeconds(kStandardUploadIntervalCellularSeconds);
 #endif
   return base::TimeDelta::FromSeconds(kStandardUploadIntervalSeconds);
 }
 
-// Returns true if current connection type is cellular and user is assigned to
-// experimental group for enabled cellular uploads.
+// Returns true if current connection type is cellular.
 bool IsCellularLogicEnabled() {
-  std::string enabled = variations::GetVariationParamValue(
-      "UMA_EnableCellularLogUpload", "Enabled");
-  std::string optimized = variations::GetVariationParamValue(
-      "UMA_EnableCellularLogUpload", "Optimize");
-  bool is_enabled = kDefaultCellularLogicEnabled;
-  if (!enabled.empty())
-    is_enabled = (enabled == "true");
-
-  bool is_optimized = kDefaultCellularLogicOptimization;
-  if (!optimized.empty())
-    is_optimized = (optimized == "true");
-
-  if (!is_enabled || !is_optimized)
-    return false;
-
   return net::NetworkChangeNotifier::IsConnectionCellular(
       net::NetworkChangeNotifier::GetConnectionType());
 }
 
 }  // namespace metrics