Refactor: move components/sync/../signin to components/signin/../

Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController to SigninManager

Associate internal CL c/289860/

BUG=567975
Committed: https://crrev.com/338144c0ff454a98eed2c64cbfa24db0629b9aa7
Cr-Commit-Position: refs/heads/master@{#421078}

[gogerald1, 2016-09-19 18:41:09]

Description was changed from

==========
refactor

BUG=
==========

to

==========
Refactor: move components/sync/../signin to components/signin/../

BUG=
==========

[gogerald1, 2016-09-19 18:45:31]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:46:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-09-19 18:49:48]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:50:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:53:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gogerald1, 2016-09-19 19:12:54]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:13:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-09-19 19:25:40]

Description was changed from

==========
Refactor: move components/sync/../signin to components/signin/../

BUG=
==========

to

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=
==========

[commit-bot: I haz the power, 2016-09-19 19:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:32:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[gogerald1, 2016-09-19 20:02:12]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-09-19 20:02:25]

Patchset #1 (id:20001) has been deleted

[gogerald1, 2016-09-19 22:24:56]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 22:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 22:50:16]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gogerald1, 2016-09-19 23:01:57]

Description was changed from

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=
==========

to

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=500104
==========

[gogerald1, 2016-09-19 23:03:57]

Description was changed from

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=500104
==========

to

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=567975
==========

[gogerald1, 2016-09-19 23:14:28]

gogerald@chromium.org changed reviewers:
+ maxbogue@chromium.org, nyquist@chromium.org, rogerta@chromium.org

[gogerald1, 2016-09-19 23:14:30]

maxbogue@chromium.org: Please review changes in 
components/sync/*

rogerta@chromium.org: Please review changes in
components/signin/* 

nyquist@chromium.org: Please review changes in 
the rest of the files

Note that trybots error is tracking in the issue
https://bugs.chromium.org/p/chromium/issues/detail?id=639042.

[maxbogue, 2016-09-20 05:44:50]

Looks like you will need to remove the dependency on //components/syncable_prefs
to proceed:

https://cs.chromium.org/chromium/src/components/signin/core/browser/BUILD.gn?...

It's creating a dependency cycle between signin and sync. Looks like it's just
used in the AccountInvestigator unittest:

https://cs.chromium.org/chromium/src/components/signin/core/browser/account_i...

[maxbogue, 2016-09-20 06:17:35]

Anyways, whether it's the syncable_prefs thing or an actual bug making the DEPS
cycle, the rest of the CL lgtm!

[skym, 2016-09-20 15:49:45]

On 2016/09/20 05:44:50, maxbogue wrote:
> Looks like you will need to remove the dependency on
//components/syncable_prefs
> to proceed:
> 
>
https://cs.chromium.org/chromium/src/components/signin/core/browser/BUILD.gn?...
> 
> It's creating a dependency cycle between signin and sync. Looks like it's just
> used in the AccountInvestigator unittest:
> 
>
https://cs.chromium.org/chromium/src/components/signin/core/browser/account_i...

Looks like you might be able to remove that dep from those unit tests. It seems
to do that because AccountTrackerService::RegisterPrefs and
SigninManagerBase::RegisterProfilePrefs take user_prefs::PrefRegistrySyncable*,
but looking at their implementation, they seem to only make PrefRegistrySimple
calls?

[gogerald1, 2016-09-20 16:59:12]

On 2016/09/20 15:49:45, skym wrote:
> On 2016/09/20 05:44:50, maxbogue wrote:
> > Looks like you will need to remove the dependency on
> //components/syncable_prefs
> > to proceed:
> > 
> >
>
https://cs.chromium.org/chromium/src/components/signin/core/browser/BUILD.gn?...
> > 
> > It's creating a dependency cycle between signin and sync. Looks like it's
just
> > used in the AccountInvestigator unittest:
> > 
> >
>
https://cs.chromium.org/chromium/src/components/signin/core/browser/account_i...
> 
> Looks like you might be able to remove that dep from those unit tests. It
seems
> to do that because AccountTrackerService::RegisterPrefs and
> SigninManagerBase::RegisterProfilePrefs take
user_prefs::PrefRegistrySyncable*,
> but looking at their implementation, they seem to only make PrefRegistrySimple
> calls?

Thanks for helping tackle DEPs problem. Have noticed syncable_prefs dependency,
but I believe we have no DEPs cycle until now, since they are in two different
layers. New dependency from components/sync/android/* to
components/signin/core/browser/android/* is in java layer, however dependency of
components/syncable_prefs is in C++ layer. I totally agree it is better to
remove dependency of "components/syncable_prefs" from "components/signin", but
might do it in separate CL.

[Roger Tawa OOO till Jul 10th, 2016-09-20 17:28:48]

lgtm

Awesome Ganggui!  This is a great cleanup of the deps between signin and sync.

[nyquist, 2016-09-23 07:36:48]

I'm not sure I understand why the java code has a cyclic dependency. I tried
locally, and I didn't reproduce the error, even when building the same targets.
Maybe this CL for some reason requires a clobber?

Also; could you check whether this would affect the internal targets, just so
no-one ends up reverting your CL because it breaks something?

Anyway, other than ensuring that this compiles correctly, overall lgtm. Awesome
job!

[gogerald1, 2016-09-23 14:26:55]

On 2016/09/23 07:36:48, nyquist wrote:
> I'm not sure I understand why the java code has a cyclic dependency. I tried
> locally, and I didn't reproduce the error, even when building the same
targets.
> Maybe this CL for some reason requires a clobber?
> 
> Also; could you check whether this would affect the internal targets, just so
> no-one ends up reverting your CL because it breaks something?
> 
> Anyway, other than ensuring that this compiles correctly, overall lgtm.
Awesome
> job!

Yes, I will land this CL with clobber which is the suggested workaround
according to this issue
https://bugs.chromium.org/p/chromium/issues/detail?id=639042. I've uploaded the
CL for internal change for review, will land them consecutively.

[nyquist, 2016-09-23 16:05:22]

On 2016/09/23 14:26:55, gogerald1 wrote:
> On 2016/09/23 07:36:48, nyquist wrote:
> > I'm not sure I understand why the java code has a cyclic dependency. I tried
> > locally, and I didn't reproduce the error, even when building the same
> targets.
> > Maybe this CL for some reason requires a clobber?
> > 
> > Also; could you check whether this would affect the internal targets, just
so
> > no-one ends up reverting your CL because it breaks something?
> > 
> > Anyway, other than ensuring that this compiles correctly, overall lgtm.
> Awesome
> > job!
> 
> Yes, I will land this CL with clobber which is the suggested workaround
> according to this issue
> https://bugs.chromium.org/p/chromium/issues/detail?id=639042. I've uploaded
the
> CL for internal change for review, will land them consecutively.

OK. Please inform the Android sheriff before you land this then. The internal CL
also lgtm.

[gogerald1, 2016-09-23 17:16:50]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 17:17:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-09-23 17:18:55]

gogerald@chromium.org changed reviewers:
+ dpranke@chromium.org

[gogerald1, 2016-09-23 17:18:56]

dpranke@chromium.org: Please review changes in 

get_landmines.py

[commit-bot: I haz the power, 2016-09-23 17:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 17:36:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gogerald1, 2016-09-23 18:37:12]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 18:38:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 20:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 20:47:18]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Dirk Pranke, 2016-09-23 23:03:33]

lgtm. 

I'm still not sure I understand why a landmine is needed and we can't resolve
this otherwise, but I don't want to block this further, either.

[gogerald1, 2016-09-26 14:02:03]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 14:02:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 14:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 14:05:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gogerald1, 2016-09-26 14:26:12]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 14:26:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 15:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 15:48:50]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[gogerald1, 2016-09-26 17:14:49]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-09-26 17:14:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org, rogerta@chromium.org, nyquist@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2351703003/#ps140001
(title: "fix InvalidationController")

[commit-bot: I haz the power, 2016-09-26 17:15:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:41:08]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[gogerald1, 2016-09-26 18:47:23]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:48:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:59:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:00:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[gogerald1, 2016-09-26 19:08:44]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:09:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 19:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:19:05]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gogerald1, 2016-09-26 20:39:22]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 20:40:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 20:44:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:44:24]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gogerald1, 2016-09-26 21:29:08]

Patchset #7 (id:160001) has been deleted

[gogerald1, 2016-09-26 22:04:49]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-09-26 22:04:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org, nyquist@chromium.org, rogerta@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2351703003/#ps180001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-26 22:05:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 23:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 23:11:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gogerald1, 2016-09-26 23:14:41]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-09-26 23:15:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 00:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 00:18:23]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gogerald1, 2016-09-27 00:56:24]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 00:57:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:42:09]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-09-27 01:44:23]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:45:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:53:04]

Description was changed from

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=567975
==========

to

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=567975
==========

[commit-bot: I haz the power, 2016-09-27 01:53:06]

Committed patchset #7 (id:180001)

[commit-bot: I haz the power, 2016-09-27 01:56:01]

Description was changed from

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=567975
==========

to

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=567975

Committed: https://crrev.com/338144c0ff454a98eed2c64cbfa24db0629b9aa7
Cr-Commit-Position: refs/heads/master@{#421078}
==========

[commit-bot: I haz the power, 2016-09-27 01:56:03]

Patchset 7 (id:??) landed as
https://crrev.com/338144c0ff454a98eed2c64cbfa24db0629b9aa7
Cr-Commit-Position: refs/heads/master@{#421078}

[gogerald1, 2016-09-27 01:59:04]

Description was changed from

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

BUG=567975

Committed: https://crrev.com/338144c0ff454a98eed2c64cbfa24db0629b9aa7
Cr-Commit-Position: refs/heads/master@{#421078}
==========

to

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

Associate internal CL
https://chrome-internal-review.googlesource.com/#/c/289860/

BUG=567975

Committed: https://crrev.com/338144c0ff454a98eed2c64cbfa24db0629b9aa7
Cr-Commit-Position: refs/heads/master@{#421078}
==========

[gogerald1, 2016-09-27 01:59:40]

Description was changed from

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

Associate internal CL
https://chrome-internal-review.googlesource.com/#/c/289860/

BUG=567975

Committed: https://crrev.com/338144c0ff454a98eed2c64cbfa24db0629b9aa7
Cr-Commit-Position: refs/heads/master@{#421078}
==========

to

==========
Refactor: move components/sync/../signin to components/signin/../

This CL also moves AndroidSyncSettings.updateAccount from ChromeSigninController
to SigninManager

Associate internal CL c/289860/

BUG=567975

Committed: https://crrev.com/338144c0ff454a98eed2c64cbfa24db0629b9aa7
Cr-Commit-Position: refs/heads/master@{#421078}
==========

[boliu, 2016-09-27 13:59:50]

Sorry, I haven't really looked, but is this error related to this CL? Not sure
why bots are green though..

[1/1] Regenerating ninja files
ninja: error: dependency cycle:
obj/components/signin/core/browser/android/java.stamp ->
obj/components/signin/core/browser/android/java__analysis.stamp ->
obj/components/signin/core/browser/android/java__lint.stamp ->
gen/components/sign
in/core/browser/android/java__lint/result.xml ->
lib.java/components/sync/android/sync_java.interface.jar ->
obj/components/sync/android/sync_java__compile_java__ijar.inputdeps.stamp ->
lib.java/components/sync/android/sync_java.jar -> ob
j/components/sync/android/sync_java__compile_java__process_prebuilt__filter.inputdeps.stamp
-> gen/components/sync/android/sync_java__compile_java.javac.jar ->
obj/components/sync/android/sync_java__compile_java__javac.inputdeps.stamp -> 
obj/components/signin/core/browser/android/java.stamp

[blundell, 2016-09-27 14:03:13]

On 2016/09/27 13:59:50, boliu wrote:
> Sorry, I haven't really looked, but is this error related to this CL? Not sure
> why bots are green though..
> 
> [1/1] Regenerating ninja files
> ninja: error: dependency cycle:
> obj/components/signin/core/browser/android/java.stamp ->
> obj/components/signin/core/browser/android/java__analysis.stamp ->
> obj/components/signin/core/browser/android/java__lint.stamp ->
> gen/components/sign
> in/core/browser/android/java__lint/result.xml ->
> lib.java/components/sync/android/sync_java.interface.jar ->
> obj/components/sync/android/sync_java__compile_java__ijar.inputdeps.stamp ->
> lib.java/components/sync/android/sync_java.jar -> ob
>
j/components/sync/android/sync_java__compile_java__process_prebuilt__filter.inputdeps.stamp
> -> gen/components/sync/android/sync_java__compile_java.javac.jar ->
> obj/components/sync/android/sync_java__compile_java__javac.inputdeps.stamp -> 
> obj/components/signin/core/browser/android/java.stamp

It is. I hit the same error locally. You can make it go away via "gn clean",
which is why there was a landmine added to this CL. I don't understand why the
landmine didn't trigger for me (or apparently for you).

[gogerald1, 2016-09-27 14:04:29]

On 2016/09/27 13:59:50, boliu wrote:
> Sorry, I haven't really looked, but is this error related to this CL? Not sure
> why bots are green though..
> 
> [1/1] Regenerating ninja files
> ninja: error: dependency cycle:
> obj/components/signin/core/browser/android/java.stamp ->
> obj/components/signin/core/browser/android/java__analysis.stamp ->
> obj/components/signin/core/browser/android/java__lint.stamp ->
> gen/components/sign
> in/core/browser/android/java__lint/result.xml ->
> lib.java/components/sync/android/sync_java.interface.jar ->
> obj/components/sync/android/sync_java__compile_java__ijar.inputdeps.stamp ->
> lib.java/components/sync/android/sync_java.jar -> ob
>
j/components/sync/android/sync_java__compile_java__process_prebuilt__filter.inputdeps.stamp
> -> gen/components/sync/android/sync_java__compile_java.javac.jar ->
> obj/components/sync/android/sync_java__compile_java__javac.inputdeps.stamp -> 
> obj/components/signin/core/browser/android/java.stamp

It relates which seems a trybot or gn issue,
https://bugs.chromium.org/p/chromium/issues/detail?id=639042. I used clobber in
this CL.

[dgn, 2016-09-27 15:04:55]

On local builds, deleting out/Debug/gen/components/signin/ works for me.