Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: build/get_landmines.py

Issue 2351703003: Refactor: move components/sync/../signin to components/signin/../ (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/client/core/settings/BUILD.gn ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
(...skipping 16 matching lines...) Expand all
27 # bandaid fix if a CL that got landed has a build dependency bug and all bots 27 # bandaid fix if a CL that got landed has a build dependency bug and all bots
28 # need to be cleaned up. If you're writing a new CL that causes build 28 # need to be cleaned up. If you're writing a new CL that causes build
29 # dependency problems, fix the dependency problems instead of adding a 29 # dependency problems, fix the dependency problems instead of adding a
30 # landmine. 30 # landmine.
31 31
32 if distributor() == 'goma' and platform() == 'win32': 32 if distributor() == 'goma' and platform() == 'win32':
33 print 'Need to clobber winja goma due to backend cwd cache fix.' 33 print 'Need to clobber winja goma due to backend cwd cache fix.'
34 if platform() == 'android': 34 if platform() == 'android':
35 print 'Clobber: to handle new way of suppressing findbugs failures.' 35 print 'Clobber: to handle new way of suppressing findbugs failures.'
36 print 'Clobber to fix gyp not rename package name (crbug.com/457038)' 36 print 'Clobber to fix gyp not rename package name (crbug.com/457038)'
37 print 'Clobber to recalculate reversed dependency (crbug.com/639042)'
37 if platform() == 'win': 38 if platform() == 'win':
38 print 'Compile on cc_unittests fails due to symbols removed in r185063.' 39 print 'Compile on cc_unittests fails due to symbols removed in r185063.'
39 if platform() == 'linux': 40 if platform() == 'linux':
40 print 'Builders switching from make to ninja will clobber on this.' 41 print 'Builders switching from make to ninja will clobber on this.'
41 if platform() == 'mac': 42 if platform() == 'mac':
42 print 'Switching from bundle to unbundled dylib (issue 14743002).' 43 print 'Switching from bundle to unbundled dylib (issue 14743002).'
43 if platform() in ('win', 'mac'): 44 if platform() in ('win', 'mac'):
44 print ('Improper dependency for create_nmf.py broke in r240802, ' 45 print ('Improper dependency for create_nmf.py broke in r240802, '
45 'fixed in r240860.') 46 'fixed in r240860.')
46 if (platform() == 'win' and gyp_msvs_version().startswith('2015')): 47 if (platform() == 'win' and gyp_msvs_version().startswith('2015')):
(...skipping 24 matching lines...) Expand all
71 print 'Clobber to remove libsystem.dylib. See crbug.com/620075' 72 print 'Clobber to remove libsystem.dylib. See crbug.com/620075'
72 73
73 74
74 def main(): 75 def main():
75 print_landmines() 76 print_landmines()
76 return 0 77 return 0
77 78
78 79
79 if __name__ == '__main__': 80 if __name__ == '__main__':
80 sys.exit(main()) 81 sys.exit(main())
OLDNEW
« no previous file with comments | « blimp/client/core/settings/BUILD.gn ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698