Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2351693002: Rework types_unittest.cc not to rely on the GetAXNode method. (Closed)

Created:
4 years, 3 months ago by aboxhall
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rework types_unittest.cc not to rely on the GetAXNode method. Should fix build breakage (https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/45952/steps/compile/logs/stdio) caused by modifying the Accessibility model in https://codereview.chromium.org/2322413003/ BUG= Committed: https://crrev.com/a94e0ecd92294853dfae6449d011cacac32dca21 Cr-Commit-Position: refs/heads/master@{#419445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M headless/public/domains/types_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
aboxhall
4 years, 3 months ago (2016-09-19 13:20:52 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 3 months ago (2016-09-19 13:24:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351693002/1
4 years, 3 months ago (2016-09-19 13:29:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 13:38:56 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 13:40:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a94e0ecd92294853dfae6449d011cacac32dca21
Cr-Commit-Position: refs/heads/master@{#419445}

Powered by Google App Engine
This is Rietveld 408576698