Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: headless/public/domains/types_unittest.cc

Issue 2351693002: Rework types_unittest.cc not to rely on the GetAXNode method. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/domains/types_unittest.cc
diff --git a/headless/public/domains/types_unittest.cc b/headless/public/domains/types_unittest.cc
index c665d95b225dc1d584c426571b1a7e0c128d8482..bf59b01151abde3e9c248fd1c0f09819b59a5f8d 100644
--- a/headless/public/domains/types_unittest.cc
+++ b/headless/public/domains/types_unittest.cc
@@ -9,23 +9,23 @@
namespace headless {
TEST(TypesTest, IntegerProperty) {
- std::unique_ptr<accessibility::GetAXNodeParams> object(
- accessibility::GetAXNodeParams::Builder().SetNodeId(123).Build());
+ std::unique_ptr<page::NavigateToHistoryEntryParams> object(
+ page::NavigateToHistoryEntryParams::Builder().SetEntryId(123).Build());
EXPECT_TRUE(object);
- EXPECT_EQ(123, object->GetNodeId());
+ EXPECT_EQ(123, object->GetEntryId());
- std::unique_ptr<accessibility::GetAXNodeParams> clone(object->Clone());
+ std::unique_ptr<page::NavigateToHistoryEntryParams> clone(object->Clone());
EXPECT_TRUE(clone);
- EXPECT_EQ(123, clone->GetNodeId());
+ EXPECT_EQ(123, clone->GetEntryId());
}
TEST(TypesTest, IntegerPropertyParseError) {
- const char* json = "{\"nodeId\": \"foo\"}";
+ const char* json = "{\"entryId\": \"foo\"}";
std::unique_ptr<base::Value> object = base::JSONReader::Read(json);
EXPECT_TRUE(object);
ErrorReporter errors;
- EXPECT_FALSE(accessibility::GetAXNodeParams::Parse(*object, &errors));
+ EXPECT_FALSE(page::NavigateToHistoryEntryParams::Parse(*object, &errors));
EXPECT_TRUE(errors.HasErrors());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698